Skip to content

🏃 OWNERS: satisfy the maintainers tool#1123

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
mercedes-benz:seanschneeweiss/owners
Feb 21, 2022
Merged

🏃 OWNERS: satisfy the maintainers tool#1123
k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
mercedes-benz:seanschneeweiss/owners

Conversation

@seanschneeweiss
Copy link
Contributor

@seanschneeweiss seanschneeweiss commented Jan 26, 2022

What this PR does / why we need it:

  • remove reviewers according to cleanup instructions
  • rename emeritus_maintainers to emeritus_approvers

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1122

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • if necessary:
    • includes documentation
    • adds unit tests

/hold
Sean Schneeweiss sean.schneeweiss@daimler.com, Daimler TSS GmbH, Provider Information

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 26, 2022
@netlify
Copy link

netlify bot commented Jan 26, 2022

✔️ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

🔨 Explore the source changes: 8df5c0e

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/61f16510de71a50007e439d9

😎 Browse the preview: https://deploy-preview-1123--kubernetes-sigs-cluster-api-openstack.netlify.app

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 26, 2022
remove reviewers
rename emeritus_maintainers to emeritus_approvers
@seanschneeweiss seanschneeweiss changed the title 🏃 OWNERS: fix #1122 to satisfy the maintainers tool 🏃 OWNERS: satisfy the maintainers tool Jan 26, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jan 26, 2022
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 26, 2022
@neolit123
Copy link
Member

thanks for the fix.

@jichenjc
Copy link
Contributor

/test pull-cluster-api-provider-openstack-e2e-test

@jichenjc
Copy link
Contributor

/lgtm

@macaptain
Copy link
Contributor

/lgtm

Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi, seanschneeweiss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [chrischdi,seanschneeweiss]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seanschneeweiss
Copy link
Contributor Author

/hold cancel

@chrischdi
Copy link
Member

I mean
/lgtm

Was already approved because @seanschneeweiss is maintainer/approver :-)

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 3, 2022
@seanschneeweiss
Copy link
Contributor Author

/retest

1 similar comment
@seanschneeweiss
Copy link
Contributor Author

/retest

@jichenjc
Copy link
Contributor

jichenjc commented Feb 7, 2022

/test pull-cluster-api-provider-openstack-e2e-test

@seanschneeweiss
Copy link
Contributor Author

e2e keeps failing

 /home/prow/go/src/sigs.k8s.io/cluster-api-provider-openstack/test/e2e/suites/e2e/e2e_suite_test.go:51
  failed to run clusterctl init
      
  Unexpected error:
      <*errors.withStack | 0xc00064cb10>: {
          error: <*errors.withMessage | 0xc00143c640>{
              cause: <*errors.withStack | 0xc00064cae0>{
                  error: <*errors.withMessage | 0xc00143c620>{
                      cause: <*runtime.missingKindErr | 0xc000eb77f0>{
                          data: "unstructured object has no kind",
                      },
                      msg: "failed to get cert-manager object /, Kind=, /",
                  },
                  stack: [0x1754f45, 0x1752bc5, 0x1756735, 0x107dadb, 0x107dbdc, 0x107db39, 0x107e51f, 0x175660c, 0x1752b25, 0x1752839, 0x17a0a5a, 0x17a759c, 0x17a8e72, 0x1870210, 0x18796b9, 0x1880025, 0x4d1505, 0x4d0a85, 0x73273a, 0x73067a, 0x730045, 0x73193e, 0x731572, 0x755b87, 0x755733, 0x7579f2, 0x763ba5, 0x7639be, 0x187d5cf, 0x513c22, 0x46b0e1],
              },
              msg: "action failed after 10 attempts",
          },
          stack: [0x1756668, 0x1752b25, 0x1752839, 0x17a0a5a, 0x17a759c, 0x17a8e72, 0x1870210, 0x18796b9, 0x1880025, 0x4d1505, 0x4d0a85, 0x73273a, 0x73067a, 0x730045, 0x73193e, 0x731572, 0x755b87, 0x755733, 0x7579f2, 0x763ba5, 0x7639be, 0x187d5cf, 0x513c22, 0x46b0e1],
      }
      action failed after 10 attempts: failed to get cert-manager object /, Kind=, /: Object 'Kind' is missing in 'unstructured object has no kind'
  occurred 

@apricote
Copy link
Member

apricote commented Feb 8, 2022

e2e keeps failing

 /home/prow/go/src/sigs.k8s.io/cluster-api-provider-openstack/test/e2e/suites/e2e/e2e_suite_test.go:51
  failed to run clusterctl init
      
  Unexpected error:
      <*errors.withStack | 0xc00064cb10>: {
          error: <*errors.withMessage | 0xc00143c640>{
              cause: <*errors.withStack | 0xc00064cae0>{
                  error: <*errors.withMessage | 0xc00143c620>{
                      cause: <*runtime.missingKindErr | 0xc000eb77f0>{
                          data: "unstructured object has no kind",
                      },
                      msg: "failed to get cert-manager object /, Kind=, /",
                  },
                  stack: [0x1754f45, 0x1752bc5, 0x1756735, 0x107dadb, 0x107dbdc, 0x107db39, 0x107e51f, 0x175660c, 0x1752b25, 0x1752839, 0x17a0a5a, 0x17a759c, 0x17a8e72, 0x1870210, 0x18796b9, 0x1880025, 0x4d1505, 0x4d0a85, 0x73273a, 0x73067a, 0x730045, 0x73193e, 0x731572, 0x755b87, 0x755733, 0x7579f2, 0x763ba5, 0x7639be, 0x187d5cf, 0x513c22, 0x46b0e1],
              },
              msg: "action failed after 10 attempts",
          },
          stack: [0x1756668, 0x1752b25, 0x1752839, 0x17a0a5a, 0x17a759c, 0x17a8e72, 0x1870210, 0x18796b9, 0x1880025, 0x4d1505, 0x4d0a85, 0x73273a, 0x73067a, 0x730045, 0x73193e, 0x731572, 0x755b87, 0x755733, 0x7579f2, 0x763ba5, 0x7639be, 0x187d5cf, 0x513c22, 0x46b0e1],
      }
      action failed after 10 attempts: failed to get cert-manager object /, Kind=, /: Object 'Kind' is missing in 'unstructured object has no kind'
  occurred 

This will be fixed by #1136

@mdbooth
Copy link
Contributor

mdbooth commented Feb 8, 2022

e2e keeps failing

 /home/prow/go/src/sigs.k8s.io/cluster-api-provider-openstack/test/e2e/suites/e2e/e2e_suite_test.go:51
  failed to run clusterctl init
      
  Unexpected error:
      <*errors.withStack | 0xc00064cb10>: {
          error: <*errors.withMessage | 0xc00143c640>{
              cause: <*errors.withStack | 0xc00064cae0>{
                  error: <*errors.withMessage | 0xc00143c620>{
                      cause: <*runtime.missingKindErr | 0xc000eb77f0>{
                          data: "unstructured object has no kind",
                      },
                      msg: "failed to get cert-manager object /, Kind=, /",
                  },
                  stack: [0x1754f45, 0x1752bc5, 0x1756735, 0x107dadb, 0x107dbdc, 0x107db39, 0x107e51f, 0x175660c, 0x1752b25, 0x1752839, 0x17a0a5a, 0x17a759c, 0x17a8e72, 0x1870210, 0x18796b9, 0x1880025, 0x4d1505, 0x4d0a85, 0x73273a, 0x73067a, 0x730045, 0x73193e, 0x731572, 0x755b87, 0x755733, 0x7579f2, 0x763ba5, 0x7639be, 0x187d5cf, 0x513c22, 0x46b0e1],
              },
              msg: "action failed after 10 attempts",
          },
          stack: [0x1756668, 0x1752b25, 0x1752839, 0x17a0a5a, 0x17a759c, 0x17a8e72, 0x1870210, 0x18796b9, 0x1880025, 0x4d1505, 0x4d0a85, 0x73273a, 0x73067a, 0x730045, 0x73193e, 0x731572, 0x755b87, 0x755733, 0x7579f2, 0x763ba5, 0x7639be, 0x187d5cf, 0x513c22, 0x46b0e1],
      }
      action failed after 10 attempts: failed to get cert-manager object /, Kind=, /: Object 'Kind' is missing in 'unstructured object has no kind'
  occurred 

This will be fixed by #1136

Unfortunately not by itself. Hopefully a combination of #1136 and kubernetes-sigs/cluster-api#6080 will do the job, though.

@jichenjc
Copy link
Contributor

/retest

@k8s-ci-robot k8s-ci-robot merged commit 7389046 into kubernetes-sigs:main Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

unknown field "emeritus_maintainers" in the OWNERS file

8 participants