🏃 OWNERS: satisfy the maintainers tool#1123
🏃 OWNERS: satisfy the maintainers tool#1123k8s-ci-robot merged 1 commit intokubernetes-sigs:mainfrom
Conversation
|
✔️ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready! 🔨 Explore the source changes: 8df5c0e 🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/61f16510de71a50007e439d9 😎 Browse the preview: https://deploy-preview-1123--kubernetes-sigs-cluster-api-openstack.netlify.app |
remove reviewers rename emeritus_maintainers to emeritus_approvers
e03faf1 to
8df5c0e
Compare
|
thanks for the fix. |
|
/test pull-cluster-api-provider-openstack-e2e-test |
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrischdi, seanschneeweiss The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
|
I mean Was already approved because @seanschneeweiss is maintainer/approver :-) |
|
/retest |
1 similar comment
|
/retest |
|
/test pull-cluster-api-provider-openstack-e2e-test |
|
e2e keeps failing |
This will be fixed by #1136 |
Unfortunately not by itself. Hopefully a combination of #1136 and kubernetes-sigs/cluster-api#6080 will do the job, though. |
|
/retest |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1122
Special notes for your reviewer:
TODOs:
/hold
Sean Schneeweiss sean.schneeweiss@daimler.com, Daimler TSS GmbH, Provider Information