Skip to content

🐛 [v0.5.0] Prevent creation of floating IPs when reconcile load balancer in non ACTIVE state#1164

Merged
k8s-ci-robot merged 1 commit intokubernetes-sigs:release-0.5from
giantswarm:cherry-pick-reconcile-handle-lb-state-1115
Mar 10, 2022
Merged

🐛 [v0.5.0] Prevent creation of floating IPs when reconcile load balancer in non ACTIVE state#1164
k8s-ci-robot merged 1 commit intokubernetes-sigs:release-0.5from
giantswarm:cherry-pick-reconcile-handle-lb-state-1115

Conversation

@tfussell
Copy link

@tfussell tfussell commented Mar 7, 2022

What this PR does / why we need it:

I have been running into this issue (#1114 #1159) often recently. It is annoying to have to clean up the extra floating IPs manually. The fix on main hasn't been released yet so I would like to backport it for release as v0.5.3.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1114
Cherry-pick of #1115

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • if necessary:
    • includes documentation
    • adds unit tests

/hold

@mgrote @tfussell
ReconcileLoadBalancer check for appropiate load balancer state implem…
a6efd9b 
…ented to prevent creation of floating ip's for load balancer with states other than ACTIVE.

Documentation link to openstack load balancer states updated.

Signed-off-by: MICHAEL GROTE <michael.grote@daimler.com>
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 7, 2022
@netlify
Copy link

netlify bot commented Mar 7, 2022 •
edited
Loading

✔️ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

🔨 Explore the source changes: a6efd9b

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/62263e5868354a000799c36e

😎 Browse the preview: https://deploy-preview-1164--kubernetes-sigs-cluster-api-openstack.netlify.app/print

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 7, 2022

Welcome @tfussell!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-openstack 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-openstack has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 7, 2022

Hi @tfussell. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 7, 2022
@mdbooth
Copy link
Contributor

mdbooth commented Mar 7, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 7, 2022
@mdbooth
Copy link
Contributor

mdbooth commented Mar 7, 2022

I would personally be ok with another 0.5.x bump containing this cherry-pick.

@jichenjc
Copy link
Contributor

jichenjc commented Mar 8, 2022

/test pull-cluster-api-provider-openstack-e2e-test

@jichenjc
Copy link
Contributor

jichenjc commented Mar 8, 2022

I am +1 to release 0.5.3

@tfussell
Copy link
Author

tfussell commented Mar 8, 2022

/retest

@tfussell
Copy link
Author

tfussell commented Mar 8, 2022

I'm not sure what the failure about cert-manager has to do with this change. Is this a normal flaky test?

@chrischdi
Copy link
Member

chrischdi commented Mar 8, 2022

I think it is not a flake and affects the release branch as well as other prs to it.

I assume this was fixed for main via #1136 by bumping the sigs.k8s.io/cluster-api/test dependency. Reason for that is: on this branch the cert-manager installation fails, which is because they changed their repo.

I started a discussion in slack about that:
https://kubernetes.slack.com/archives/CFKJB65G9/p1646774509558269

Maybe I could take a look at it tomorrow and add a PR to fix CI for the release branch.

@chrischdi chrischdi mentioned this pull request Mar 9, 2022
Merged
3 tasks
@chrischdi
Copy link
Member

chrischdi commented Mar 9, 2022

/retest

@jichenjc
Copy link
Contributor

jichenjc commented Mar 10, 2022

/approve
/lgtm

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 10, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 10, 2022
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 10, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc, tfussell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2022
@k8s-ci-robot k8s-ci-robot merged commit 650bc13 into kubernetes-sigs:release-0.5 Mar 10, 2022
@garloff garloff mentioned this pull request Mar 18, 2022
Closed
@apricote apricote mentioned this pull request Apr 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jichenjc jichenjc Awaiting requested review from jichenjc

@prankul88 prankul88 Awaiting requested review from prankul88

Assignees

@jichenjc jichenjc

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tfussell @k8s-ci-robot @mdbooth @jichenjc @chrischdi @mgrote