🐛Remove v1.0.x as CAPO don't have that version until now#1135
🐛Remove v1.0.x as CAPO don't have that version until now#1135jichenjc wants to merge 1 commit intokubernetes-sigs:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jichenjc The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
✔️ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready! 🔨 Explore the source changes: 30d2060 🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/620222ba449f1a0007156ff0 😎 Browse the preview: https://deploy-preview-1135--kubernetes-sigs-cluster-api-openstack.netlify.app |
|
@jichenjc: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/hold not sure this is required, need further analysis |
|
@sbueringer If I understood your comment correctly this is required? I confess I don't 100% understand what this is doing either. |
|
@mdbooth The dropped lines tell clusterctl that there is a v1.0.x CAPO release series compatible with the CAPI v1beta1 contract. Based on that clusterctl tries to find a CAPO v1.0.x release which doesn't exist. clusterctl always tries to install the newest release of a provider compatible with the current (v1beta1) contract, if no infra provider version is specified explicitly in |
Thanks. So @jichenjc I think we do need this. |
|
I think we're going to need #1136 for CI to pass. |
|
FYI, in discussion with @sbueringer on slack I've pulled this change into #1136 to see if we need both fixes for CI to be green again. |
|
I am trying to upgrade to 1.1.0 through #1137 |
|
as we have embeded this into another PR, no need for this anymore |
What this PR does / why we need it:
during release v0.5.1 found issue kubernetes-sigs/cluster-api#6076
turn out to be our own problem
I manually updated this file in release manifest
https://github.com/kubernetes-sigs/cluster-api-provider-openstack/releases/download/v0.5.1/metadata.yaml
and with this PR we should remove those definitions
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Related: #1129
Fixes: #1134
Special notes for your reviewer:
TODOs:
/hold