Skip to content

🐛Remove v1.0.x as CAPO don't have that version until now#1135

Closed
jichenjc wants to merge 1 commit intokubernetes-sigs:mainfrom
jichenjc:update_metadata_yaml
Closed

🐛Remove v1.0.x as CAPO don't have that version until now#1135
jichenjc wants to merge 1 commit intokubernetes-sigs:mainfrom
jichenjc:update_metadata_yaml

Conversation

@jichenjc
Copy link
Contributor

@jichenjc jichenjc commented Feb 8, 2022

What this PR does / why we need it:

during release v0.5.1 found issue kubernetes-sigs/cluster-api#6076
turn out to be our own problem
I manually updated this file in release manifest
https://github.com/kubernetes-sigs/cluster-api-provider-openstack/releases/download/v0.5.1/metadata.yaml
and with this PR we should remove those definitions

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Related: #1129
Fixes: #1134

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • if necessary:
    • includes documentation
    • adds unit tests

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 8, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2022
@netlify
Copy link

netlify bot commented Feb 8, 2022

✔️ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

🔨 Explore the source changes: 30d2060

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/620222ba449f1a0007156ff0

😎 Browse the preview: https://deploy-preview-1135--kubernetes-sigs-cluster-api-openstack.netlify.app

@k8s-ci-robot
Copy link
Contributor

@jichenjc: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-openstack-e2e-test 30d2060 link true /test pull-cluster-api-provider-openstack-e2e-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jichenjc
Copy link
Contributor Author

jichenjc commented Feb 8, 2022

/hold

not sure this is required, need further analysis

@mdbooth
Copy link
Contributor

mdbooth commented Feb 8, 2022

@sbueringer If I understood your comment correctly this is required? I confess I don't 100% understand what this is doing either.

@sbueringer
Copy link
Member

sbueringer commented Feb 8, 2022

@mdbooth The dropped lines tell clusterctl that there is a v1.0.x CAPO release series compatible with the CAPI v1beta1 contract.

Based on that clusterctl tries to find a CAPO v1.0.x release which doesn't exist. clusterctl always tries to install the newest release of a provider compatible with the current (v1beta1) contract, if no infra provider version is specified explicitly in clusterctl init.

@mdbooth
Copy link
Contributor

mdbooth commented Feb 8, 2022

@mdbooth The dropped lines tell clusterctl that there is a v1.0.x CAPO release series compatible with the CAPI v1beta1 contract.

Based on that clusterctl tries to find a CAPO v1.0.x release which doesn't exist. clusterctl always tries to install the newest release of a provider compatible with the current (v1beta1) contract, if no infra provider version is specified explicitly in clusterctl init.

Thanks. So @jichenjc I think we do need this.

@mdbooth
Copy link
Contributor

mdbooth commented Feb 8, 2022

I think we're going to need #1136 for CI to pass.

@mdbooth
Copy link
Contributor

mdbooth commented Feb 8, 2022

FYI, in discussion with @sbueringer on slack I've pulled this change into #1136 to see if we need both fixes for CI to be green again.

@jichenjc
Copy link
Contributor Author

jichenjc commented Feb 9, 2022

I am trying to upgrade to 1.1.0 through #1137
but encounter kubernetes-sigs/cluster-api#6076 again though I did update the metadata.yaml ... so need figure out what's really wrong there

https://storage.googleapis.com/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api-provider-openstack/1137/pull-cluster-api-provider-openstack-e2e-test/1491317277604188160/build-log.txt

@jichenjc
Copy link
Contributor Author

as we have embeded this into another PR, no need for this anymore

@jichenjc jichenjc closed this Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

metadatas.yaml should not have 1.0.x definition

4 participants