Skip to content

Embed CNI configmap in prow CI templates#1333

Merged
k8s-ci-robot merged 2 commits into
kubernetes-sigs:masterfrom
CecileRobertMichon:cni-prow
Apr 28, 2021
Merged

Embed CNI configmap in prow CI templates#1333
k8s-ci-robot merged 2 commits into
kubernetes-sigs:masterfrom
CecileRobertMichon:cni-prow

Conversation

@CecileRobertMichon
Copy link
Copy Markdown
Contributor

@CecileRobertMichon CecileRobertMichon commented Apr 23, 2021

What type of PR is this?

What this PR does / why we need it: Apply changes from https://github.com/kubernetes-sigs/cluster-api-provider-azure/pull/1287/files#diff-2d2faf7aecdc4844f880039bc558bf1054f7807269a2c0dad794276e90dee1e4R16 to the other CI templates so that CNI is applied automatically when deploying these from ci-entrypoint or others.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

Embed CNI configmap in prow CI templates

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Apr 23, 2021
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 23, 2021
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels Apr 23, 2021
@CecileRobertMichon
Copy link
Copy Markdown
Contributor Author

CecileRobertMichon commented Apr 23, 2021

@chewong I didn't touch test/dev/cluster-template-custom-builds.yaml, I'll let you add it if needed in #1264

@CecileRobertMichon
Copy link
Copy Markdown
Contributor Author

CecileRobertMichon commented Apr 23, 2021

/test ls

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 23, 2021

@CecileRobertMichon: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-cluster-api-provider-azure-test
  • /test pull-cluster-api-provider-azure-build
  • /test pull-cluster-api-provider-azure-e2e
  • /test pull-cluster-api-provider-azure-e2e-full
  • /test pull-cluster-api-provider-azure-e2e-windows
  • /test pull-cluster-api-provider-azure-capi-e2e
  • /test pull-cluster-api-provider-azure-verify
  • /test pull-cluster-api-provider-azure-conformance-v1alpha4
  • /test pull-cluster-api-provider-azure-upstream-v1alpha4-windows
  • /test pull-cluster-api-provider-azure-conformance-with-ci-artifacts
  • /test pull-cluster-api-provider-azure-apidiff
  • /test pull-cluster-api-provider-azure-coverage

Use /test all to run the following jobs:

  • pull-cluster-api-provider-azure-test
  • pull-cluster-api-provider-azure-build
  • pull-cluster-api-provider-azure-e2e
  • pull-cluster-api-provider-azure-e2e-windows
  • pull-cluster-api-provider-azure-verify
  • pull-cluster-api-provider-azure-apidiff
  • pull-cluster-api-provider-azure-coverage
Details

In response to this:

/test ls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@CecileRobertMichon
Copy link
Copy Markdown
Contributor Author

CecileRobertMichon commented Apr 23, 2021

/test pull-cluster-api-provider-azure-conformance-v1alpha4
/test pull-cluster-api-provider-azure-conformance-with-ci-artifacts
/test pull-cluster-api-provider-azure-capi-e2e

chewong
chewong reviewed Apr 23, 2021
View reviewed changes
Comment thread templates/test/ci/prow-machine-pool-windows/kustomization.yaml Outdated
Comment thread templates/test/ci/prow-ipv6/kustomization.yaml
@CecileRobertMichon
Copy link
Copy Markdown
Contributor Author

CecileRobertMichon commented Apr 23, 2021

/test pull-cluster-api-provider-azure-conformance-v1alpha4
/test pull-cluster-api-provider-azure-conformance-with-ci-artifacts
/test pull-cluster-api-provider-azure-capi-e2e

@CecileRobertMichon
Copy link
Copy Markdown
Contributor Author

CecileRobertMichon commented Apr 24, 2021

/test pull-cluster-api-provider-azure-conformance-v1alpha4
/test pull-cluster-api-provider-azure-conformance-with-ci-artifacts
/test pull-cluster-api-provider-azure-capi-e2e

@CecileRobertMichon
Copy link
Copy Markdown
Contributor Author

CecileRobertMichon commented Apr 25, 2021

/test pull-cluster-api-provider-azure-conformance-v1alpha4
/test pull-cluster-api-provider-azure-conformance-with-ci-artifacts
/test pull-cluster-api-provider-azure-capi-e2e

@CecileRobertMichon
Copy link
Copy Markdown
Contributor Author

CecileRobertMichon commented Apr 26, 2021

/retest

@CecileRobertMichon
Copy link
Copy Markdown
Contributor Author

CecileRobertMichon commented Apr 26, 2021

/test pull-cluster-api-provider-azure-conformance-v1alpha4
/test pull-cluster-api-provider-azure-conformance-with-ci-artifacts
/test pull-cluster-api-provider-azure-capi-e2e

CecileRobertMichon
CecileRobertMichon commented Apr 26, 2021
View reviewed changes
Comment thread scripts/ci-conformance.sh
}

export LOCAL_ONLY=${LOCAL_ONLY:-"false"}
export LOCAL_ONLY=${LOCAL_ONLY:-"true"}
Copy link
Copy Markdown
Contributor Author

@CecileRobertMichon CecileRobertMichon Apr 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chewong you might need to update any jobs that need to push conformance artifacts to an outside registry to have LOCAL_ONLY set to true.

Copy link
Copy Markdown
Contributor Author

@CecileRobertMichon CecileRobertMichon Apr 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kubernetes/test-infra#21953

@CecileRobertMichon
Copy link
Copy Markdown
Contributor Author

CecileRobertMichon commented Apr 26, 2021

/test pull-cluster-api-provider-azure-conformance-v1alpha4
/test pull-cluster-api-provider-azure-conformance-with-ci-artifacts
/test pull-cluster-api-provider-azure-capi-e2e

@CecileRobertMichon
Copy link
Copy Markdown
Contributor Author

CecileRobertMichon commented Apr 26, 2021

/assign @chewong @nader-ziada

chewong
chewong reviewed Apr 26, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@chewong chewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 26, 2021
@CecileRobertMichon
Copy link
Copy Markdown
Contributor Author

CecileRobertMichon commented Apr 26, 2021

/hold until kubernetes/test-infra#21953 merges

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 26, 2021
@chewong chewong mentioned this pull request Apr 26, 2021
Merged
3 tasks
@nader-ziada
Copy link
Copy Markdown
Contributor

nader-ziada commented Apr 27, 2021

/lgtm

approve pending the test-infra PR merge

@nader-ziada
Copy link
Copy Markdown
Contributor

nader-ziada commented Apr 28, 2021

/approve

test-infra pr merged
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 28, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 28, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nader-ziada

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2021
@nader-ziada
Copy link
Copy Markdown
Contributor

nader-ziada commented Apr 28, 2021

/test pull-cluster-api-provider-azure-e2e-windows

@CecileRobertMichon
Copy link
Copy Markdown
Contributor Author

CecileRobertMichon commented Apr 28, 2021

/retest

flake from #1328

@CecileRobertMichon
Copy link
Copy Markdown
Contributor Author

CecileRobertMichon commented Apr 28, 2021

/retest

:(

@CecileRobertMichon
Copy link
Copy Markdown
Contributor Author

CecileRobertMichon commented Apr 28, 2021

/retest

@jsturtevant getting hit by the windows deploy issue repetitively here

@CecileRobertMichon
Copy link
Copy Markdown
Contributor Author

CecileRobertMichon commented Apr 28, 2021

/retest

@jsturtevant
Copy link
Copy Markdown
Contributor

jsturtevant commented Apr 28, 2021

getting hit by the windows deploy issue repetitively here

Seems like this got worse today. I will try to repo it

@CecileRobertMichon
Copy link
Copy Markdown
Contributor Author

CecileRobertMichon commented Apr 28, 2021

I'm going to override the windows job, I've verified that all clusters have built successfully and the windows deployment issue is unrelated to this change. This PR fixes the conformance jobs and unblocks #1330.

/override pull-cluster-api-provider-azure-e2e-windows

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 28, 2021

@CecileRobertMichon: Overrode contexts on behalf of CecileRobertMichon: pull-cluster-api-provider-azure-e2e-windows

Details

In response to this:

I'm going to override the windows job, I've verified that all clusters have built successfully and the windows deployment issue is unrelated to this change. This PR fixes the conformance jobs and unblocks #1330.

/override pull-cluster-api-provider-azure-e2e-windows

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot merged commit 14941f8 into kubernetes-sigs:master Apr 28, 2021
@k8s-ci-robot k8s-ci-robot added this to the v0.5.0 milestone Apr 28, 2021
jsturtevant added a commit to jsturtevant/cluster-api-provider-azure that referenced this pull request May 6, 2021
@jsturtevant
kubernetes-sigs#1333 dropped kubeproxy from ci deployments
2d7ffdc
This was referenced May 6, 2021
Merged
Merged
@CecileRobertMichon CecileRobertMichon deleted the cni-prow branch February 17, 2023 22:59
willie-yao pushed a commit to willie-yao/cluster-api-provider-azure that referenced this pull request Jul 11, 2025
@irvokopo
Onboard cert-manager v1.17.2 (kubernetes-sigs#1333)
090c173
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nader-ziada nader-ziada Awaiting requested review from nader-ziada

@shysank shysank Awaiting requested review from shysank

1 more reviewer

@chewong chewong chewong left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@nader-ziada nader-ziada

@chewong chewong

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

v0.5.0

Development

Successfully merging this pull request may close these issues.

5 participants

@CecileRobertMichon @k8s-ci-robot @nader-ziada @jsturtevant @chewong