ci: run conformance with presubmit artifacts hosted on Azure by chewong · Pull Request #1264 · kubernetes-sigs/cluster-api-provider-azure

chewong · 2021-03-24T18:31:07Z

What type of PR is this?

What this PR does / why we need it:

/kind feature

Build and upload Kubernetes artifacts built from a k/k PR to Azure blob storage and ACR, and allow CAPZ clusters to consume them at runtime.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

squashed commits
includes documentation
adds unit tests

Release note:

Build and upload Kubernetes artifacts build from a k/k PR to Azure blob storage and ACR, and allow CAPZ clusters to consume them at runtime.

k8s-ci-robot · 2021-03-24T18:31:09Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

chewong · 2021-03-24T21:22:37Z

Original Error: Code=\"PlatformImageNotFound\" Message=\"The platform image 'cncf-upstream:capi:k8s-1dot21dot0-ubuntu-1804:latest' is not available.

@CecileRobertMichon do you know what the best platform image I should be using for a pre-released version like v1.21.0? The default assumes that the image is already published.

CecileRobertMichon · 2021-03-24T22:21:03Z

@chewong see https://github.com/kubernetes-sigs/cluster-api-provider-azure/blob/master/templates/test/prow-ci-version/patches/azuremachine-marketplace-image.yaml

chewong · 2021-04-20T22:15:39Z

/uncc alexeldeib nader-ziada

chewong · 2021-04-20T23:38:03Z

This PR is ready for review.

Successful conformance test pass with Kubernetes build from HEAD - https://storage.googleapis.com/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api-provider-azure/1264/pull-cluster-api-provider-azure-conformance-v1alpha4/1384618091463315456/build-log.txt

CecileRobertMichon · 2021-04-26T23:05:44Z

+capz::util::should_build_kubernetes() {
+    # JOB_TYPE, REPO_OWNER, and REPO_NAME are enviornment variables set by a prow job -
+    # https://github.com/kubernetes/test-infra/blob/master/prow/jobs.md#job-environment-variables
+    if [[ "${JOB_TYPE:-}" == "presubmit" ]] && [[ "${REPO_OWNER:-}/${REPO_NAME:-}" == "kubernetes/kubernetes" ]]; then


it might be convenient to allow overriding this to true to allow running this test suite locally to test a k/k change, WDYT?

(non-blocking, can be a follow up)

CecileRobertMichon · 2021-04-26T23:07:45Z

/test pull-cluster-api-provider-azure-conformance-v1alpha4
/test pull-cluster-api-provider-azure-conformance-with-ci-artifacts

chewong · 2021-04-26T23:12:19Z

Looks like this PR is depending on #1333. I'll rebase once it's merged.

CecileRobertMichon · 2021-04-26T23:20:19Z

Looks like this PR is depending on #1333. I'll rebase once it's merged.

hopefully, kubernetes/test-infra#21953 merges soon.

In the meantime, any doc updates required in https://capz.sigs.k8s.io/developers/kubernetes-developers.html#testing-clusters-built-from-kubernetes-source ?

chewong · 2021-04-26T23:52:15Z

Looks like this PR is depending on #1333. I'll rebase once it's merged.

hopefully, kubernetes/test-infra#21953 merges soon.

In the meantime, any doc updates required in https://capz.sigs.k8s.io/developers/kubernetes-developers.html#testing-clusters-built-from-kubernetes-source ?

I think the required docs update is related to #1264 (comment), since the script is meant for the CI environment for now. I can open a follow-up PR to address both at the same time.

jackfrancis · 2021-04-27T16:16:07Z

Looks like two tests failed due to a part in the script where it bails if $REGISTRY is not set.

./scripts/ci-conformance.sh: line 60: REGISTRY: Environment variable empty or not defined.

chewong · 2021-04-27T16:39:56Z

Looks like two tests failed due to a part in the script where it bails if $REGISTRY is not set.

./scripts/ci-conformance.sh: line 60: REGISTRY: Environment variable empty or not defined.

#1333 should fix this issue

CecileRobertMichon · 2021-04-28T22:07:17Z

@chewong go ahead and rebase now that #1333 has merged

chewong · 2021-04-28T22:20:46Z

@CecileRobertMichon rebased. Ready for a final round of review

CecileRobertMichon · 2021-04-30T17:16:07Z

/test pull-cluster-api-provider-azure-conformance-v1alpha4
/test pull-cluster-api-provider-azure-conformance-with-ci-artifacts

Signed-off-by: Ernest Wong <chuwon@microsoft.com>

chewong · 2021-04-30T18:27:01Z

/test pull-cluster-api-provider-azure-conformance-v1alpha4
/test pull-cluster-api-provider-azure-conformance-with-ci-artifacts

chewong · 2021-04-30T20:59:40Z

/retest

CecileRobertMichon · 2021-04-30T21:33:54Z

/lgtm
/approve

k8s-ci-robot · 2021-04-30T21:34:02Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [CecileRobertMichon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jackfrancis

lgtm

chewong · 2021-04-30T22:00:36Z

/retest

chewong · 2021-05-03T16:08:36Z

/retest

chewong · 2021-05-03T19:06:40Z

/retest

dims · 2021-07-26T20:41:14Z

/cc

k8s-ci-robot requested review from alexeldeib and nader-ziada March 24, 2021 18:31

k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 24, 2021

chewong closed this Mar 25, 2021

chewong reopened this Mar 25, 2021

CecileRobertMichon reviewed Mar 26, 2021

View reviewed changes

Comment thread docs/topics/kubernetes-developers.md Outdated

CecileRobertMichon reviewed Mar 26, 2021

View reviewed changes

Comment thread scripts/ci-entrypoint.sh Outdated

chewong mentioned this pull request Apr 1, 2021

test: cluster template for building from custom images #1246

Merged

3 tasks

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 5, 2021

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 14, 2021

chewong changed the title ~~[WIP] ci: build and upload Kubernetes artifacts to Azure~~ [WIP] ci: run conformance with presubmit artifacts hosted on Azure Apr 19, 2021

k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 19, 2021

k8s-ci-robot removed request for alexeldeib and nader-ziada April 20, 2021 22:15

chewong marked this pull request as ready for review April 20, 2021 23:37

chewong commented Apr 20, 2021

View reviewed changes

Comment thread templates/test/dev/custom-builds/patches/custom-builds.yaml

CecileRobertMichon reviewed Apr 26, 2021

View reviewed changes

jackfrancis mentioned this pull request Apr 28, 2021

capz: update presubmit test target branches kubernetes/test-infra#22001

Merged

CecileRobertMichon reviewed Apr 30, 2021

View reviewed changes

Comment thread templates/test/dev/custom-builds/patches/custom-builds.yaml

ci: run conformance with presubmit artifacts hosted on Azure

1887f80

Signed-off-by: Ernest Wong <chuwon@microsoft.com>

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 30, 2021

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2021

jackfrancis approved these changes Apr 30, 2021

View reviewed changes

k8s-ci-robot merged commit d1bf8dd into kubernetes-sigs:master May 3, 2021

k8s-ci-robot added this to the v0.5.0 milestone May 3, 2021

chewong mentioned this pull request May 4, 2021

docs: add docs on using custom K8s on a capz cluster #1364

Merged

3 tasks

chewong mentioned this pull request Jun 7, 2021

test: custom K8s build on machine pool #1419

Merged

3 tasks

CecileRobertMichon mentioned this pull request Jun 23, 2021

Custom K8s build testing #1314

Closed

8 tasks

k8s-ci-robot requested a review from dims July 26, 2021 20:41

Conversation

chewong commented Mar 24, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Mar 24, 2021

Uh oh!

chewong commented Mar 24, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CecileRobertMichon commented Mar 24, 2021

Uh oh!

Uh oh!

Uh oh!

chewong commented Apr 20, 2021

Uh oh!

chewong commented Apr 20, 2021

Uh oh!

Uh oh!

CecileRobertMichon Apr 26, 2021

Choose a reason for hiding this comment

Uh oh!

CecileRobertMichon Apr 26, 2021

Choose a reason for hiding this comment

Uh oh!

CecileRobertMichon commented Apr 26, 2021

Uh oh!

chewong commented Apr 26, 2021

Uh oh!

CecileRobertMichon commented Apr 26, 2021

Uh oh!

chewong commented Apr 26, 2021

Uh oh!

jackfrancis commented Apr 27, 2021

Uh oh!

chewong commented Apr 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CecileRobertMichon commented Apr 28, 2021

Uh oh!

chewong commented Apr 28, 2021

Uh oh!

Uh oh!

CecileRobertMichon commented Apr 30, 2021

Uh oh!

chewong commented Apr 30, 2021

Uh oh!

chewong commented Apr 30, 2021

Uh oh!

CecileRobertMichon commented Apr 30, 2021

Uh oh!

k8s-ci-robot commented Apr 30, 2021

Uh oh!

jackfrancis left a comment

Choose a reason for hiding this comment

Uh oh!

chewong commented Apr 30, 2021

Uh oh!

chewong commented May 3, 2021

Uh oh!

chewong commented May 3, 2021

Uh oh!

dims commented Jul 26, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

chewong commented Mar 24, 2021 •

edited

Loading

chewong commented Mar 24, 2021 •

edited

Loading

chewong commented Apr 27, 2021 •

edited

Loading