External Azure cloud provider clusters with custom CCM and CNM images#1330
Merged
k8s-ci-robot merged 2 commits intoMay 5, 2021
Merged
Conversation
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
sig/cluster-lifecycle
|
|
||
| # Install cert manager and wait for availability | ||
| kubectl apply -f https://github.com/jetstack/cert-manager/releases/download/v1.0.1/cert-manager.yaml | ||
| kubectl apply -f https://github.com/jetstack/cert-manager/releases/download/v1.1.0/cert-manager.yaml |
Contributor
Author
There was a problem hiding this comment.
this was a typo, it should be 1.0.1 to align with CAPI https://github.com/kubernetes-sigs/cluster-api/blob/master/docs/book/src/developer/providers/v1alpha3-to-v1alpha4.md#upgrade-cert-manager-to-v110
CecileRobertMichon
force-pushed
the
ccm-presubmit-tests
branch
from
780dea5 to
8d74602
Compare
k8s-ci-robot
added
size/L
CecileRobertMichon
force-pushed
the
ccm-presubmit-tests
branch
2 times, most recently
from
cc593b5 to
eb911f6
Compare
CecileRobertMichon
force-pushed
the
ccm-presubmit-tests
branch
from
eb911f6 to
1b9231c
Compare
devigned
reviewed
Apr 22, 2021
Contributor
devigned
left a comment
devigned
left a comment
There was a problem hiding this comment.
Looks good so far. Left some feedback about ACR repos and clean up tasks.
3 tasks
3 tasks
CecileRobertMichon
force-pushed
the
ccm-presubmit-tests
branch
from
604024e to
a6dfeda
Compare
3 tasks
k8s-ci-robot
added
the
needs-rebase
CecileRobertMichon
force-pushed
the
ccm-presubmit-tests
branch
from
a6dfeda to
559659a
Compare
k8s-ci-robot
added
size/M
CecileRobertMichon
force-pushed
the
ccm-presubmit-tests
branch
from
559659a to
0db2fb6
Compare
k8s-ci-robot
added
size/XXL
k8s-ci-robot
added
size/L
CecileRobertMichon
force-pushed
the
ccm-presubmit-tests
branch
from
a88fb65 to
cd2de2f
Compare
CecileRobertMichon
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Contributor
Author
|
This is ready for review test results in kubernetes-sigs/cloud-provider-azure#607 |
CecileRobertMichon
force-pushed
the
ccm-presubmit-tests
branch
from
cd2de2f to
8707c65
Compare
chewong
reviewed
May 3, 2021
CecileRobertMichon
force-pushed
the
ccm-presubmit-tests
branch
from
8707c65 to
739d03a
Compare
k8s-ci-robot
added
release-note
Contributor
Author
|
@devigned @nader-ziada if one of you has time to review, need this to merge before I can enable the job on cloud provider. |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: devigned The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Contributor
Author
|
/retest |
1 similar comment
Contributor
Author
|
/retest |
Contributor
Author
|
@jsturtevant having trouble merging this one, is #1351 testing a mitigation for the web deployment timeouts on windows? /retest |
Contributor
Author
|
/retest |
willie-yao
pushed a commit
to willie-yao/cluster-api-provider-azure
that referenced
this pull request
Jul 11, 2025
Co-authored-by: Brian Chuo <110847365+bchuo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it: This adds a script for building custom CCM and CNM images from the azure-cloud-provider repo to be used with scripts/ci-entrypoint.sh to build clusters with a custom version of Azure external cloud provider installed.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
PR is currently based on top of #1264, will rebase before merge.Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs:
Release note: