Skip to content

Clean up the CNI CRS which is done via generators#1371

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:masterfrom
jsturtevant:fix-windows-cni-ci
May 7, 2021
Merged

Clean up the CNI CRS which is done via generators#1371
k8s-ci-robot merged 1 commit into
kubernetes-sigs:masterfrom
jsturtevant:fix-windows-cni-ci

Conversation

@jsturtevant
Copy link
Copy Markdown
Contributor

What type of PR is this?
/kind bug
/kind cleanup
/kind failing-test

What this PR does / why we need it:
#1333 moved all the cni configuration for CI to kustomize generators. This left out kube-proxy for Windows with caused failures in the tests in #1119.

The code that was configuring the CNI during the e2e suite is no longer required as well.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

NONE

/assign @chewong @CecileRobertMichon

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 7, 2021
@k8s-ci-robot k8s-ci-robot added area/provider/azure Issues or PRs related to azure provider sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 7, 2021
@jsturtevant jsturtevant force-pushed the fix-windows-cni-ci branch from d98922c to eddb72d Compare May 7, 2021 18:29
@nader-ziada
Copy link
Copy Markdown
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 7, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nader-ziada

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2021
@k8s-ci-robot k8s-ci-robot merged commit 9d34960 into kubernetes-sigs:master May 7, 2021
@k8s-ci-robot k8s-ci-robot added this to the v0.5.0 milestone May 7, 2021
@jsturtevant jsturtevant mentioned this pull request May 7, 2021
5 tasks
@CecileRobertMichon
Copy link
Copy Markdown
Contributor

looks like https://testgrid.k8s.io/sig-cluster-lifecycle-cluster-api-provider-azure#capz-periodic-capi-e2e-main is failing since this merged with:

    Unexpected error:
        <*yamlprocessor.errMissingVariables | 0xc001048000>: {
            Missing: ["CNI_RESOURCES"],
        }
        value for variables [CNI_RESOURCES] is not set. Please set the value using os environment variables or the clusterctl config file
    occurred
    ```
    
We need to either re-add the CNI_RESOURCES variables, or add CNIs to the templates in https://github.com/kubernetes-sigs/cluster-api-provider-azure/blob/master/test/e2e/data/infrastructure-azure 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants