Skip to content

Azure: Set LOCAL_ONLY as part of anonymous pull preset#21953

Merged
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
CecileRobertMichon:add-registry
Apr 28, 2021
Merged

Azure: Set LOCAL_ONLY as part of anonymous pull preset#21953
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
CecileRobertMichon:add-registry

Conversation

@CecileRobertMichon
Copy link
Copy Markdown
Member

@CecileRobertMichon CecileRobertMichon commented Apr 26, 2021

When using the preset-azure-anonymous-pull preset which sets REGISTRY to "capzci.azurecr.io", we should always set LOCAL_ONLY to false. This PR adds it to the preset so we don't have to add it to every single job that uses the preset.

/assign @chewong @devigned

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 26, 2021
@CecileRobertMichon CecileRobertMichon mentioned this pull request Apr 26, 2021
Merged
3 tasks
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 26, 2021
@k8s-ci-robot k8s-ci-robot added area/jobs area/provider/azure Issues or PRs related to azure provider sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Apr 26, 2021
chewong
chewong reviewed Apr 26, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@chewong chewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 26, 2021
@CecileRobertMichon
Copy link
Copy Markdown
Member Author

CecileRobertMichon commented Apr 26, 2021

/assign @chases2

@CecileRobertMichon CecileRobertMichon mentioned this pull request Apr 26, 2021
Merged
3 tasks
@devigned
Copy link
Copy Markdown
Contributor

devigned commented Apr 27, 2021

/lgtm

1 similar comment
@nader-ziada
Copy link
Copy Markdown

nader-ziada commented Apr 27, 2021

/lgtm

@CecileRobertMichon
Copy link
Copy Markdown
Member Author

CecileRobertMichon commented Apr 27, 2021

/assign @spiffxp

@BenTheElder
Copy link
Copy Markdown
Member

BenTheElder commented Apr 28, 2021

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 28, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2021
@k8s-ci-robot k8s-ci-robot merged commit 4b45fe3 into kubernetes:master Apr 28, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Apr 28, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 28, 2021

@CecileRobertMichon: Updated the following 2 configmaps:

  • job-config configmap in namespace default at cluster test-infra-trusted using the following files:
    • key cluster-api-provider-azure-periodics-release-0-4.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-azure/cluster-api-provider-azure-periodics-release-0-4.yaml
    • key cluster-api-provider-azure-periodics.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-azure/cluster-api-provider-azure-periodics.yaml
    • key cluster-api-provider-azure-postsubmits-release-0-4.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-azure/cluster-api-provider-azure-postsubmits-release-0-4.yaml
    • key cluster-api-provider-azure-postsubmits.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-azure/cluster-api-provider-azure-postsubmits.yaml
    • key cluster-api-provider-azure-presubmits-release-0-4.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-azure/cluster-api-provider-azure-presubmits-release-0-4.yaml
    • key cluster-api-provider-azure-presubmits.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-azure/cluster-api-provider-azure-presubmits.yaml
  • config configmap in namespace default at cluster test-infra-trusted using the following files:
    • key config.yaml using file config/prow/config.yaml
Details

In response to this:

When using the preset-azure-anonymous-pull preset which sets REGISTRY to "capzci.azurecr.io", we should always set LOCAL_ONLY to false. This PR adds it to the preset so we don't have to add it to every single job that uses the preset.

/assign @chewong @devigned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cblecker cblecker Awaiting requested review from cblecker

@chases2 chases2 Awaiting requested review from chases2

@juan-lee juan-lee Awaiting requested review from juan-lee

1 more reviewer

@chewong chewong chewong left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@spiffxp spiffxp

@devigned devigned

@chases2 chases2

@nader-ziada nader-ziada

@chewong chewong

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

v1.22

Development

Successfully merging this pull request may close these issues.

8 participants

@CecileRobertMichon @devigned @nader-ziada @BenTheElder @k8s-ci-robot @chewong @spiffxp @chases2