Skip to content

capz: update presubmit test target branches#22001

Merged
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
jackfrancis:capz-ha-control-plane-final
May 3, 2021
Merged

capz: update presubmit test target branches#22001
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
jackfrancis:capz-ha-control-plane-final

Conversation

@jackfrancis
Copy link
Copy Markdown
Contributor

@jackfrancis jackfrancis commented Apr 28, 2021 •
edited
Loading

In expectation of this PR being merged soon:

kubernetes-sigs/cluster-api-provider-azure#1264

... this PR updates the pull-kubernetes-e2e-capz-ha-control-plane and pull-kubernetes-e2e-capz-conformance test specs so that they derive the capz-specific bits from the master branch.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 28, 2021
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs area/provider/azure Issues or PRs related to azure provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Apr 28, 2021
@jackfrancis jackfrancis force-pushed the capz-ha-control-plane-final branch from 6012eeb to 34d1293 Compare April 28, 2021 20:06
@jackfrancis jackfrancis changed the title capz: use master branch spec for ha control plane test capz: use master branch spec for conformance tests Apr 28, 2021
@chewong
Copy link
Copy Markdown
Member

chewong commented Apr 28, 2021

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 28, 2021
@jackfrancis jackfrancis deleted the capz-ha-control-plane-final branch April 29, 2021 23:36
@jackfrancis jackfrancis restored the capz-ha-control-plane-final branch April 30, 2021 21:36
@jackfrancis jackfrancis reopened this Apr 30, 2021
@jackfrancis jackfrancis changed the title capz: use master branch spec for conformance tests capz: update presubmit test target branches Apr 30, 2021
@jackfrancis
use master capz branch spec for conformance test
e73d975 
use dev branch for in-progress HA conformance test
@jackfrancis jackfrancis force-pushed the capz-ha-control-plane-final branch from 34d1293 to e73d975 Compare May 3, 2021 20:40
chewong
chewong approved these changes May 3, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@chewong chewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 3, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 3, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chewong, jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 3, 2021
@jackfrancis
Copy link
Copy Markdown
Contributor Author

jackfrancis commented May 3, 2021

/hold release

@chewong
Copy link
Copy Markdown
Member

chewong commented May 3, 2021

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 3, 2021
@jackfrancis
Copy link
Copy Markdown
Contributor Author

jackfrancis commented May 3, 2021

/what Ernest said

@k8s-ci-robot k8s-ci-robot merged commit 6ca0bea into kubernetes:master May 3, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 3, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented May 3, 2021

@jackfrancis: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key release-master.yaml using file config/jobs/kubernetes/sig-cloud-provider/azure/release-master.yaml
Details

In response to this:

In expectation of this PR being merged soon:

kubernetes-sigs/cluster-api-provider-azure#1264

... this PR updates the pull-kubernetes-e2e-capz-ha-control-plane and pull-kubernetes-e2e-capz-conformance test specs so that they derive the capz-specific bits from the master branch.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jackfrancis jackfrancis deleted the capz-ha-control-plane-final branch May 3, 2021 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@feiskyer feiskyer Awaiting requested review from feiskyer

@justaugustus justaugustus Awaiting requested review from justaugustus

1 more reviewer

@chewong chewong chewong approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@chewong chewong

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v1.22

Development

Successfully merging this pull request may close these issues.

3 participants

@jackfrancis @chewong @k8s-ci-robot