test: cluster template for building from custom images by jackfrancis · Pull Request #1246 · kubernetes-sigs/cluster-api-provider-azure

jackfrancis · 2021-03-16T23:44:16Z

What type of PR is this?

What this PR does / why we need it:

This PR establishes a standard prow template for creating clusters from custom upstream build artifacts.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

squashed commits
includes documentation
adds unit tests

Release note:

NONE

k8s-ci-robot · 2021-03-16T23:44:24Z

Hi @jackfrancis. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jackfrancis · 2021-03-16T23:44:40Z

cc @chewong

This is WIP at present

jackfrancis · 2021-03-23T17:04:56Z

cc @chewong

This is WIP at present

No longer true, this new template is tested working via tilt (and documented in this PR as such)

CecileRobertMichon · 2021-04-05T16:53:52Z

@jackfrancis @chewong how do this and #1264 relate? Do we need both or is #1264 a superset?

chewong · 2021-04-05T17:27:36Z

@jackfrancis @chewong how do this and #1264 relate? Do we need both or is #1264 a superset?

#1264 was built on top of this PR. I will continue working on #1264 once this is merged.

chewong · 2021-04-05T19:28:35Z

In the meantime, can we move forward on this PR?

CecileRobertMichon · 2021-04-05T19:49:13Z

/ok-to-test

CecileRobertMichon · 2021-04-05T19:49:19Z

/test ls

CecileRobertMichon · 2021-04-14T21:48:43Z

+    - content: |
+        #!/bin/bash
+
+        retrycmd() {


I'm not a huge fan of having this complex bash script in line in the template, would be good if we can move it to a separate file and inject it at some point (follow up). Also it should really live in https://github.com/kubernetes-sigs/cluster-api/tree/master/test/framework/kubernetesversions/data, there's nothing here that's Azure provider specific.

CecileRobertMichon · 2021-04-14T22:48:37Z

@jackfrancis overall this is a good start, pending my last 2 comments (revert tiltfile change and docs + use default as base), lgtm

I opened #1314 to track further improvements that I'd like us to explore as follow up, no need to block this though, this is great progress.

CecileRobertMichon · 2021-04-19T21:11:46Z

/lgtm
/approve

as mentioned above. let's merge and iterate. We can track TODOs in #1314.

k8s-ci-robot · 2021-04-19T21:11:53Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [CecileRobertMichon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…31 (kubernetes-sigs#1246)

k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. area/provider/azure Issues or PRs related to azure provider labels Mar 16, 2021

k8s-ci-robot requested review from alexeldeib and cpanato March 16, 2021 23:44

k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 16, 2021

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 16, 2021

jackfrancis force-pushed the custom-images branch from a85e575 to 95f42a0 Compare March 22, 2021 21:04

jackfrancis changed the title ~~test: prow template for building from custom images~~ test: cluster template for building from custom images Mar 22, 2021

k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 22, 2021

jackfrancis force-pushed the custom-images branch 2 times, most recently from f306aa7 to b5862b4 Compare March 23, 2021 00:01

chewong reviewed Apr 1, 2021

View reviewed changes

Comment thread docs/topics/kubernetes-developers.md

Comment thread templates/flavors/custom-builds/patches/custom-builds.yaml

Comment thread templates/flavors/custom-builds/patches/custom-builds.yaml Outdated

chewong reviewed Apr 1, 2021

View reviewed changes

Comment thread docs/topics/kubernetes-developers.md Outdated

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 5, 2021

jackfrancis force-pushed the custom-images branch from 994c986 to bba7fa4 Compare April 6, 2021 21:56

CecileRobertMichon reviewed Apr 12, 2021

View reviewed changes

Comment thread templates/flavors/custom-builds/patches/custom-builds.yaml Outdated

jackfrancis force-pushed the custom-images branch 4 times, most recently from b33037a to ce73e0c Compare April 14, 2021 16:32

chewong reviewed Apr 14, 2021

View reviewed changes

Comment thread docs/topics/kubernetes-developers.md Outdated

Comment thread templates/test/dev/custom-builds/kustomization.yaml Outdated

jackfrancis force-pushed the custom-images branch from ce73e0c to 066f864 Compare April 14, 2021 19:29

CecileRobertMichon reviewed Apr 14, 2021

View reviewed changes

Comment thread Tiltfile Outdated

CecileRobertMichon reviewed Apr 14, 2021

View reviewed changes

CecileRobertMichon mentioned this pull request Apr 14, 2021

Custom K8s build testing #1314

Closed

8 tasks

jackfrancis force-pushed the custom-images branch 2 times, most recently from 02f2da7 to 880a38e Compare April 14, 2021 23:31

jackfrancis commented Apr 14, 2021

View reviewed changes

Comment thread templates/test/dev/cluster-template-custom-builds.yaml Outdated

CecileRobertMichon reviewed Apr 15, 2021

View reviewed changes

Comment thread docs/topics/kubernetes-developers.md Outdated

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 15, 2021

jackfrancis force-pushed the custom-images branch from 880a38e to c9392a5 Compare April 19, 2021 20:45

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 19, 2021

test: cluster template for building from custom images

2e0c1d6

jackfrancis force-pushed the custom-images branch from c9392a5 to 2e0c1d6 Compare April 19, 2021 20:48

k8s-ci-robot assigned CecileRobertMichon Apr 19, 2021

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 19, 2021

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2021

k8s-ci-robot merged commit bbb0867 into kubernetes-sigs:master Apr 19, 2021

k8s-ci-robot added this to the v0.5.0 milestone Apr 19, 2021

jackfrancis deleted the custom-images branch December 9, 2022 23:04

willie-yao pushed a commit to willie-yao/cluster-api-provider-azure that referenced this pull request Jul 11, 2025

Bump local-path-provision v0.0.30 for Azure Linux, add spec for v0.0.…

bb0e148

…31 (kubernetes-sigs#1246)

Conversation

jackfrancis commented Mar 16, 2021

Uh oh!

k8s-ci-robot commented Mar 16, 2021

Uh oh!

jackfrancis commented Mar 16, 2021

Uh oh!

jackfrancis commented Mar 23, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CecileRobertMichon commented Apr 5, 2021

Uh oh!

chewong commented Apr 5, 2021

Uh oh!

chewong commented Apr 5, 2021

Uh oh!

CecileRobertMichon commented Apr 5, 2021

Uh oh!

CecileRobertMichon commented Apr 5, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CecileRobertMichon Apr 14, 2021

Choose a reason for hiding this comment

Uh oh!

CecileRobertMichon commented Apr 14, 2021

Uh oh!

Uh oh!

Uh oh!

CecileRobertMichon commented Apr 19, 2021

Uh oh!

k8s-ci-robot commented Apr 19, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants