Skip to content
This repository has been archived by the owner on Sep 19, 2022. It is now read-only.

Move PyTorch Operator e2e tests to AWS Prow #305

Merged
merged 21 commits into from
Oct 22, 2020
Merged

Move PyTorch Operator e2e tests to AWS Prow #305

merged 21 commits into from
Oct 22, 2020

Conversation

Jeffwan
Copy link
Member

@Jeffwan Jeffwan commented Oct 17, 2020

No description provided.

@PatrickXYS
Copy link
Member

/lgtm

@Jeffwan
Copy link
Member Author

Jeffwan commented Oct 18, 2020

/retest

1 similar comment
@Jeffwan
Copy link
Member Author

Jeffwan commented Oct 18, 2020

/retest

@Jeffwan
Copy link
Member Author

Jeffwan commented Oct 18, 2020

sdk test failure:

 ls /usr/local/lib/py*
/usr/local/lib/python3.6:
dist-packages

/usr/local/lib/python3.8:
dist-packages

table_logger actually is installed in 3.6. however, we have two python envs in the package and pytest use 3.8 which doesn't have dependency

@k8s-ci-robot k8s-ci-robot removed the lgtm label Oct 18, 2020
@Jeffwan
Copy link
Member Author

Jeffwan commented Oct 18, 2020

/test ?

@aws-kf-ci-bot
Copy link

@Jeffwan: The following commands are available to trigger jobs:

  • /test presubmit-pytorch-e2e

Use /test all to run all jobs.

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link

@Jeffwan: The following commands are available to trigger jobs:

  • /test kubeflow-pytorch-operator-presubmit

Use /test all to run all jobs.

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Jeffwan Jeffwan force-pushed the aws_test_infra branch 4 times, most recently from 0b17ba3 to d13b055 Compare October 18, 2020 17:55
@k8s-ci-robot
Copy link

@Jeffwan: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
kubeflow-pytorch-operator-presubmit d13b055 link /test kubeflow-pytorch-operator-presubmit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@PatrickXYS
Copy link
Member

/test ?

@k8s-ci-robot
Copy link

@PatrickXYS: No presubmit jobs available for kubeflow/pytorch-operator@master

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aws-kf-ci-bot
Copy link

@PatrickXYS: The following commands are available to trigger jobs:

  • /test presubmit-pytorch-e2e

Use /test all to run all jobs.

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@PatrickXYS
Copy link
Member

@PatrickXYS: No presubmit jobs available for kubeflow/pytorch-operator@master

This still suffices even though we don't have Upstream Prow Prsubmit Enabled

@PatrickXYS
Copy link
Member

/test presubmit-pytorch-e2e

@k8s-ci-robot
Copy link

@PatrickXYS: No presubmit jobs available for kubeflow/pytorch-operator@master

In response to this:

/test presubmit-pytorch-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andreyvelich
Copy link
Member

@Jeffwan @PatrickXYS Can you add LGTM on this PR: #293, please?
That should fix travis unit test.

@Jeffwan
Copy link
Member Author

Jeffwan commented Oct 20, 2020

I think the only one left is we want aws-bot report test status on the PR. Besides that, everything looks good to me

@andreyvelich
Copy link
Member

@Jeffwan Yes.
Try to rebase to fix unit tests

@coveralls
Copy link

coveralls commented Oct 20, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 64.11% when pulling 47054e5 on Jeffwan:aws_test_infra into 3ae9808 on kubeflow:master.

@PatrickXYS
Copy link
Member

/test presubmit-pytorch-e2e

1 similar comment
@Jeffwan
Copy link
Member Author

Jeffwan commented Oct 22, 2020

/test presubmit-pytorch-e2e

@k8s-ci-robot
Copy link

@PatrickXYS: No presubmit jobs available for kubeflow/pytorch-operator@master

In response to this:

/test presubmit-pytorch-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link

@Jeffwan: No presubmit jobs available for kubeflow/pytorch-operator@master

In response to this:

/test presubmit-pytorch-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@PatrickXYS
Copy link
Member

/test?

@aws-kf-ci-bot
Copy link

@PatrickXYS: The following commands are available to trigger jobs:

  • /test kubeflow-pytorch-operator-presubmit

Use /test all to run all jobs.

In response to this:

/test?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link

@PatrickXYS: No presubmit jobs available for kubeflow/pytorch-operator@master

In response to this:

/test?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@PatrickXYS
Copy link
Member

/test ?

@aws-kf-ci-bot
Copy link

@PatrickXYS: The following commands are available to trigger jobs:

  • /test kubeflow-pytorch-operator-presubmit

Use /test all to run all jobs.

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link

@PatrickXYS: No presubmit jobs available for kubeflow/pytorch-operator@master

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Jeffwan Jeffwan mentioned this pull request Oct 22, 2020
Merged
@PatrickXYS PatrickXYS mentioned this pull request Oct 22, 2020
Merged
@Jeffwan
Copy link
Member Author

Jeffwan commented Oct 22, 2020

/cc @gaocegege @johnugeorge

gaocegege
gaocegege reviewed Oct 22, 2020
View reviewed changes
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege, Jeffwan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gaocegege
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit d88cafe into kubeflow:master Oct 22, 2020
This was referenced Oct 22, 2020
Closed
Closed
Closed
Closed
Open
Open
Closed
@PatrickXYS PatrickXYS mentioned this pull request Oct 26, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gaocegege gaocegege gaocegege left review comments

@andreyvelich andreyvelich Awaiting requested review from andreyvelich

@jinchihe jinchihe Awaiting requested review from jinchihe

@johnugeorge johnugeorge Awaiting requested review from johnugeorge

Assignees

@gaocegege gaocegege

@PatrickXYS PatrickXYS

Labels
approved lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Jeffwan @PatrickXYS @aws-kf-ci-bot @k8s-ci-robot @andreyvelich @coveralls @gaocegege