Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Kubeflow Katib and training operators presubmit jobs #19657

Merged
merged 1 commit into from
Oct 26, 2020
Merged

Remove Kubeflow Katib and training operators presubmit jobs #19657

merged 1 commit into from
Oct 26, 2020

Conversation

Jeffwan
Copy link
Contributor

@Jeffwan Jeffwan commented Oct 22, 2020 •
edited
Loading

POC to move presubmit jobs to AWS prow is working.

AWS prow runs presubmit jobs and sig-testing prow tide (kubeflow-ci-bot) merges PR.

Here's the PRs with new bot working.
kubeflow/pytorch-operator#305
kubeflow/katib#1356

/cc @andreyvelich @jlewi
/cc @johnugeorge @gaocegege @terrytangyuan @ChanYiLin

I hold to PR to make sure training operator owners are aware of this.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Oct 22, 2020
@Jeffwan
Copy link
Contributor Author

Jeffwan commented Oct 22, 2020

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 22, 2020
@Jeffwan Jeffwan changed the title Remove presubmit job for Kubeflow training operators Remove Kubeflow training operators presubmit jobs Oct 22, 2020
@Jeffwan Jeffwan changed the title Remove Kubeflow training operators presubmit jobs Remove Kubeflow Katib and training operators presubmit jobs Oct 22, 2020
andreyvelich
andreyvelich reviewed Oct 22, 2020
View reviewed changes
Copy link
Contributor

@andreyvelich andreyvelich left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also disable pytorch-operator, mpi-operator, ?

@andreyvelich
Copy link
Contributor

/cc @johnugeorge @gaocegege @jlewi @terrytangyuan @ChanYiLin

@k8s-ci-robot
Copy link
Contributor

@andreyvelich: GitHub didn't allow me to request PR reviews from the following users: johnugeorge, gaocegege, terrytangyuan, ChanYiLin.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @johnugeorge @gaocegege @jlewi @terrytangyuan @ChanYiLin

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Jeffwan
Copy link
Contributor Author

Jeffwan commented Oct 22, 2020

@andreyvelich pytorch-operator has been deleted previously in a separate PR for POC purpose. mpi-operator is there.

Let's update this in slack channel to notify everyone and I will create some issues in those repos to track process of test migration

terrytangyuan
terrytangyuan reviewed Oct 22, 2020
View reviewed changes
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove MPI's presubmit as well since we are mostly just using Travis for now.

@PatrickXYS
Copy link
Contributor

/test pull-test-infra-bazel

@PatrickXYS
Copy link
Contributor

overally lgtm

@Jeffwan
Copy link
Contributor Author

Jeffwan commented Oct 22, 2020

/test pull-test-infra-bazel

@Jeffwan
Copy link
Contributor Author

Jeffwan commented Oct 22, 2020 •
edited
Loading

rebase master changes.

@Jeffwan
Copy link
Contributor Author

Jeffwan commented Oct 22, 2020

#19662 pull-test-infra-bazel failure is tracked in this issue. this is not related to the PR

@gaocegege
Copy link
Contributor

Should we fix the failure then merge it?

@PatrickXYS
Copy link
Contributor

/test pull-test-infra-bazel

@Jeffwan
Copy link
Contributor Author

Jeffwan commented Oct 23, 2020

Should we fix the failure then merge it?

@gaocegege Yeah, seems sig-testing folks fix the issue.

@PatrickXYS
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

@PatrickXYS: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@PatrickXYS
Copy link
Contributor

/cc @jlewi @clarketm Can you help approve the PR since you are OWNERS?

@Jeffwan
Copy link
Contributor Author

Jeffwan commented Oct 23, 2020

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 23, 2020
andreyvelich
andreyvelich approved these changes Oct 23, 2020
View reviewed changes
Copy link
Contributor

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

@andreyvelich: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Jeffwan
Copy link
Contributor Author

Jeffwan commented Oct 23, 2020

/assign @jlewi

@andreyvelich andreyvelich mentioned this pull request Oct 24, 2020
Merged
@jlewi
Copy link
Contributor

jlewi commented Oct 26, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 26, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, Jeffwan, jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 26, 2020
@k8s-ci-robot k8s-ci-robot merged commit d99c567 into kubernetes:master Oct 26, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Oct 26, 2020
@k8s-ci-robot
Copy link
Contributor

@Jeffwan: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key kubeflow-presubmits.yaml using file config/jobs/kubeflow/kubeflow-presubmits.yaml

In response to this:

POC to move presubmit jobs to AWS prow is working.

AWS prow runs presubmit jobs and sig-testing prow tide (kubeflow-ci-bot) merges PR.

Here's the PRs with new bot working.
kubeflow/pytorch-operator#305
kubeflow/katib#1356

/cc @andreyvelich @jlewi
/cc @johnugeorge @gaocegege @terrytangyuan @ChanYiLin

I hold to PR to make sure training operator owners are aware of this.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Jeffwan Jeffwan deleted the remove_training_presubmit branch October 26, 2020 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrytangyuan terrytangyuan terrytangyuan left review comments

@andreyvelich andreyvelich andreyvelich approved these changes

@clarketm clarketm Awaiting requested review from clarketm

@jlewi jlewi Awaiting requested review from jlewi

Assignees

@jlewi jlewi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.
7 participants
@Jeffwan @andreyvelich @k8s-ci-robot @PatrickXYS @gaocegege @jlewi @terrytangyuan