-
Notifications
You must be signed in to change notification settings - Fork 143
Conversation
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
d2a4c5a
to
82c5320
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/assign @johnugeorge
/approve Thanks for your contribution! 🎉 👍 |
@Jeffwan: No presubmit jobs available for kubeflow/pytorch-operator@master In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test kubeflow-pytorch-operator-presubmit |
@Jeffwan: No presubmit jobs available for kubeflow/pytorch-operator@master In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I think you might need to first merge #305, then you can make the presubmit pass |
@PatrickXYS Right, I ask them to approve the PR and then I can do a rebase |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich, gaocegege, Jeffwan, johnugeorge The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
82c5320
to
f1d2e72
Compare
/lgtm |
I would like to add myself to approvers. I am working on
kubeflow/common
and other operators a lot and I am pretty familiar with the code base. Currently I am working on pytorch test infra migration and pytorch kubeflow/common migration. Hope to gain access to iterate faster.Not that many PRs against PyTorch but I would like to contribute more.
https://github.com/kubeflow/pytorch-operator/pulls/Jeffwan
/cc @johnugeorge @gaocegege