Skip to content
This repository has been archived by the owner on Sep 19, 2022. It is now read-only.

Add Jeffwan@ to OWNERS #306

Merged
merged 1 commit into from
Oct 22, 2020
Merged

Conversation

Jeffwan
Copy link
Member

@Jeffwan Jeffwan commented Oct 21, 2020

I would like to add myself to approvers. I am working on kubeflow/common and other operators a lot and I am pretty familiar with the code base. Currently I am working on pytorch test infra migration and pytorch kubeflow/common migration. Hope to gain access to iterate faster.

Not that many PRs against PyTorch but I would like to contribute more.
https://github.com/kubeflow/pytorch-operator/pulls/Jeffwan

/cc @johnugeorge @gaocegege

@google-cla
Copy link

google-cla bot commented Oct 21, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@coveralls
Copy link

coveralls commented Oct 21, 2020

Coverage Status

Coverage remained the same at 64.11% when pulling f1d2e72 on Jeffwan:add_approvers into d88cafe on kubeflow:master.

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/assign @johnugeorge

@gaocegege
Copy link
Member

/approve

Thanks for your contribution! 🎉 👍

@k8s-ci-robot
Copy link

@Jeffwan: No presubmit jobs available for kubeflow/pytorch-operator@master

In response to this:

/test kubeflow-pytorch-operator-presubmit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Jeffwan
Copy link
Member Author

Jeffwan commented Oct 22, 2020

/test kubeflow-pytorch-operator-presubmit

@k8s-ci-robot
Copy link

@Jeffwan: No presubmit jobs available for kubeflow/pytorch-operator@master

In response to this:

/test kubeflow-pytorch-operator-presubmit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@PatrickXYS
Copy link
Member

I think you might need to first merge #305, then you can make the presubmit pass

@Jeffwan
Copy link
Member Author

Jeffwan commented Oct 22, 2020

@PatrickXYS Right, I ask them to approve the PR and then I can do a rebase

@johnugeorge
Copy link
Member

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, gaocegege, Jeffwan, johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [gaocegege,johnugeorge]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@PatrickXYS
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 518f9c7 into kubeflow:master Oct 22, 2020
@Jeffwan Jeffwan deleted the add_approvers branch October 22, 2020 18:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants