Skip to content
This repository has been archived by the owner on Sep 19, 2022. It is now read-only.

Add test friendly manifests #303

Closed
wants to merge 1 commit into from

Conversation

Jeffwan
Copy link
Member

@Jeffwan Jeffwan commented Sep 10, 2020

Resolve #302

  1. We can use kubectl apply -k manifests/ to deploy pytorch-operator now.
  2. Images can be changed by following commands.
kustomize edit set image gcr.io/kubeflow-images-public/pytorch-operator=${REGISTRY}/pytorch-operator:$(TAG)

This will be used to deprecate https://github.com/kubeflow/pytorch-operator/blob/master/scripts/setup-kubeflow.sh later.

test scripts will be in separate PR along with other changes

@k8s-ci-robot
Copy link

@Jeffwan: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
kubeflow-pytorch-operator-presubmit b2becd6 link /test kubeflow-pytorch-operator-presubmit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Jeffwan
Copy link
Member Author

Jeffwan commented Oct 20, 2020

/cc @johnugeorge @gaocegege

Let's merge some pending PRs.

images:
- name: gcr.io/kubeflow-images-public/pytorch-operator
newName: gcr.io/kubeflow-images-public/pytorch-operator
newTag: vmaster-gd596e904
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we deploy latest tag for controller in pytorch-operator repo by default?
What do you think?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sense. I will make the change.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to latest

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Jeffwan
To complete the pull request process, please assign johnugeorge after the PR has been reviewed.
You can assign the PR to them by writing /assign @johnugeorge in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coveralls
Copy link

Coverage Status

Coverage remained the same at 64.11% when pulling c7b3709 on Jeffwan:test_friendly_manifest into 3ae9808 on kubeflow:master.

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Jeffwan!
@johnugeorge Do we need to add podgroup.yaml to the Kustomize manifests?

@aws-kf-ci-bot
Copy link

@Jeffwan: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
kubeflow-pytorch-operator-presubmit c7b3709 link /test kubeflow-pytorch-operator-presubmit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Jeffwan
Copy link
Member Author

Jeffwan commented Oct 22, 2020

this #305 already include the changes. I will close this PR

@Jeffwan Jeffwan closed this Oct 22, 2020
@Jeffwan Jeffwan deleted the test_friendly_manifest branch October 22, 2020 16:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make manifest test friendly
5 participants