-
Notifications
You must be signed in to change notification settings - Fork 143
Conversation
@Jeffwan: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Let's merge some pending PRs. |
manifests/kustomization.yaml
Outdated
images: | ||
- name: gcr.io/kubeflow-images-public/pytorch-operator | ||
newName: gcr.io/kubeflow-images-public/pytorch-operator | ||
newTag: vmaster-gd596e904 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we deploy latest
tag for controller in pytorch-operator repo by default?
What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make sense. I will make the change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to latest
b2becd6
to
c7b3709
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Jeffwan The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Jeffwan!
@johnugeorge Do we need to add podgroup.yaml
to the Kustomize manifests?
@Jeffwan: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
this #305 already include the changes. I will close this PR |
Resolve #302
kubectl apply -k manifests/
to deploy pytorch-operator now.This will be used to deprecate https://github.com/kubeflow/pytorch-operator/blob/master/scripts/setup-kubeflow.sh later.
test scripts will be in separate PR along with other changes