Skip to content
This repository has been archived by the owner on Sep 19, 2022. It is now read-only.

Support manifest on Kubernetes 1.16+ #301

Closed
wants to merge 0 commits into from

Conversation

Jeffwan
Copy link
Member

@Jeffwan Jeffwan commented Sep 10, 2020

Update Deployment apiVersion from extensions/v1beta1 to apps/v1

@Jeffwan
Copy link
Member Author

Jeffwan commented Sep 10, 2020

/cc @jinchihe @andreyvelich

@k8s-ci-robot
Copy link

@Jeffwan: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
kubeflow-pytorch-operator-presubmit af18022 link /test kubeflow-pytorch-operator-presubmit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Jeffwan
Copy link
Member Author

Jeffwan commented Oct 20, 2020

/cc @johnugeorge @gaocegege

Let's merge some pending PRs.

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm label Oct 22, 2020
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Jeffwan
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Jeffwan
Copy link
Member Author

Jeffwan commented Oct 22, 2020

PR #305 already includes this PR. I will close the issue

@Jeffwan Jeffwan deleted the support_1.16 branch October 22, 2020 16:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants