Add dep-collector and licenseclassifier to prow-tests image#22
Merged
google-prow-robot merged 1 commit intoknative:masterfrom Jul 21, 2018
adrcunha:license-checker
Merged
Add dep-collector and licenseclassifier to prow-tests image#22google-prow-robot merged 1 commit intoknative:masterfrom adrcunha:license-checker
google-prow-robot merged 1 commit intoknative:masterfrom
adrcunha:license-checker
Conversation
These two tools are used during presubmit tests for checking the licenses in dependencies.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrcunha The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-prow-robot
added
approved
jessiezcc
reviewed
Jul 21, 2018
| RUN apt-get install -y uuid-runtime # for uuidgen | ||
| RUN go get github.com/google/go-containerregistry/cmd/ko | ||
| RUN go get github.com/golang/dep/cmd/dep | ||
| RUN go get github.com/mattmoor/dep-collector |
Contributor
There was a problem hiding this comment.
@mattmoor , will dep-collector be merged into ko later?
Contributor
|
Better to rename dep-collector repo later (@mattmoor), but looks good for now. |
Contributor
Author
|
Yes, Matt has furher plans for his tool, but right now we mostly want to get the license generation fixed. |
Member
|
@jessiezcc @adrcunha This was a tactical short-term thing to unblock us, I really don't want to maintain We should talk to the OSPO folks that own https://github.com/google/licenseclassifier about taking on ownership so that teams like us, K8s and Istio don't have to roll our own, and can have some sort of presubmit checking for forbidden licenses (as we now do). At the very least, we should find this repo a better home :) |
This was referenced Jul 22, 2018
google-prow-robot
pushed a commit
to knative/build
that referenced
this pull request
Jul 22, 2018
* Use dep-collector from prow-tests image We're consolidating the test infrastructure into a single place, so all repos get the same fixes, updates and new features. `dep-collector` was added to prow-tests image in knative/test-infra#22 and `update_licenses()` in knative/test-infra#24 Bonus: also remove `ko` as a dependency, since it's also already installed in prow-tests image. * Fix comment
google-prow-robot
pushed a commit
to knative/eventing
that referenced
this pull request
Jul 23, 2018
We're consolidating the test infrastructure into a single place, so all repos get the same fixes, updates and new features. `dep-collector` was added to prow-tests image in knative/test-infra#22 and `update_licenses()` in knative/test-infra#24 Bonus: also remove `ko` as a dependency, since it's also already installed in prow-tests image.
google-prow-robot
pushed a commit
to knative/serving
that referenced
this pull request
Jul 23, 2018
We're consolidating the test infrastructure into a single place, so all repos get the same fixes, updates and new features. dep-collector was added to prow-tests image in knative/test-infra#22
bbrowning
pushed a commit
to bbrowning/serving
that referenced
this pull request
Oct 5, 2018
We're consolidating the test infrastructure into a single place, so all repos get the same fixes, updates and new features. dep-collector was added to prow-tests image in knative/test-infra#22
vdemeester
pushed a commit
to vdemeester/knative-build
that referenced
this pull request
Apr 3, 2019
* Use dep-collector from prow-tests image We're consolidating the test infrastructure into a single place, so all repos get the same fixes, updates and new features. `dep-collector` was added to prow-tests image in knative/test-infra#22 and `update_licenses()` in knative/test-infra#24 Bonus: also remove `ko` as a dependency, since it's also already installed in prow-tests image. * Fix comment
vdemeester
pushed a commit
to vdemeester/knative-build
that referenced
this pull request
Apr 3, 2019
* Use dep-collector from prow-tests image We're consolidating the test infrastructure into a single place, so all repos get the same fixes, updates and new features. `dep-collector` was added to prow-tests image in knative/test-infra#22 and `update_licenses()` in knative/test-infra#24 Bonus: also remove `ko` as a dependency, since it's also already installed in prow-tests image. * Fix comment
Cynocracy
pushed a commit
to Cynocracy/test-infra
that referenced
this pull request
Jun 13, 2020
Cynocracy
pushed a commit
to Cynocracy/test-infra
that referenced
this pull request
Jul 22, 2020
* Removes unwanted timeout setting * fix timeouts in unit test
Cynocracy
pushed a commit
to Cynocracy/test-infra
that referenced
this pull request
Jul 22, 2020
This reverts commit 4439f50.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These two tools are used during presubmit tests for checking the licenses in dependencies.