This repository was archived by the owner on Sep 5, 2019. It is now read-only.
Use dep-collector from prow-tests image#275
Merged
google-prow-robot merged 2 commits intoknative:masterfrom Jul 22, 2018
adrcunha:simpler-license-check
Merged
Use dep-collector from prow-tests image#275google-prow-robot merged 2 commits intoknative:masterfrom adrcunha:simpler-license-check
google-prow-robot merged 2 commits intoknative:masterfrom
adrcunha:simpler-license-check
Conversation
We're consolidating the test infrastructure into a single place, so all repos get the same fixes, updates and new features. `dep-collector` was added to prow-tests image in knative/test-infra#22 and `update_licenses()` in knative/test-infra#24 Bonus: also remove `ko` as a dependency, since it's also already installed in prow-tests image.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrcunha, ImJasonH The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
vdemeester
pushed a commit
to vdemeester/knative-build
that referenced
this pull request
Apr 3, 2019
* Use dep-collector from prow-tests image We're consolidating the test infrastructure into a single place, so all repos get the same fixes, updates and new features. `dep-collector` was added to prow-tests image in knative/test-infra#22 and `update_licenses()` in knative/test-infra#24 Bonus: also remove `ko` as a dependency, since it's also already installed in prow-tests image. * Fix comment
vdemeester
pushed a commit
to vdemeester/knative-build
that referenced
this pull request
Apr 3, 2019
* Use dep-collector from prow-tests image We're consolidating the test infrastructure into a single place, so all repos get the same fixes, updates and new features. `dep-collector` was added to prow-tests image in knative/test-infra#22 and `update_licenses()` in knative/test-infra#24 Bonus: also remove `ko` as a dependency, since it's also already installed in prow-tests image. * Fix comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're consolidating the test infrastructure into a single place, so all repos get the same fixes, updates and new features.
dep-collectorwas added to prow-tests image in knative/test-infra#22 andupdate_licenses()in knative/test-infra#24Bonus: also remove
koas a dependency, since it's also already installed in prow-tests image.