Use dep-collector from prow-tests image#262
Use dep-collector from prow-tests image#262google-prow-robot merged 1 commit intoknative:masterfrom adrcunha:simpler-license-check
Conversation
We're consolidating the test infrastructure into a single place, so all repos get the same fixes, updates and new features. `dep-collector` was added to prow-tests image in knative/test-infra#22 and `update_licenses()` in knative/test-infra#24 Bonus: also remove `ko` as a dependency, since it's also already installed in prow-tests image.
google-prow-robot
added
the
size/S
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrcunha, evankanderson The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-prow-robot
added
the
approved
| [ -f /workspace/library.sh ] \ | ||
| && source /workspace/library.sh \ | ||
| || eval "$(docker run --entrypoint sh gcr.io/knative-tests/test-infra/prow-tests -c 'cat library.sh')" | ||
| [ -v KNATIVE_TEST_INFRA ] || exit 1 |
There was a problem hiding this comment.
This line breaks mac.
./hack/../hack/update-deps.sh: line 21: [: -v: unary operator expected
There was a problem hiding this comment.
Whatever check for env var KNATIVE_TEST_INFRA that works on Mac and Linux is fine.
There was a problem hiding this comment.
looking into it a little, -v is just not supported on macs default bash install.
There was a problem hiding this comment.
If you're in a hurry, simply replace that with a check that $KNATIVE_TEST_INFRA is defined. If you can wait a little bit, now that things are stable I'm gonna vendor the test-infra repo so this check will go away.
4 participants
We're consolidating the test infrastructure into a single place, so all repos get the same fixes, updates and new features.
dep-collectorwas added to prow-tests image in knative/test-infra#22 andupdate_licenses()in knative/test-infra#24Bonus: also remove
koas a dependency, since it's also already installed in prow-tests image.