Use dep-collector from prow-tests image#1649
Merged
google-prow-robot merged 1 commit intoknative:masterfrom Jul 23, 2018
adrcunha:simpler-dep-and-license
Merged
Use dep-collector from prow-tests image#1649google-prow-robot merged 1 commit intoknative:masterfrom adrcunha:simpler-dep-and-license
google-prow-robot merged 1 commit intoknative:masterfrom
adrcunha:simpler-dep-and-license
Conversation
We're consolidating the test infrastructure into a single place, so all repos get the same fixes, updates and new features. dep-collector was added to prow-tests image in knative/test-infra#22
google-prow-robot
added
the
size/S
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrcunha, mattmoor The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-prow-robot
added
the
approved
Member
|
/hold run ./hack/update-deps.sh |
google-prow-robot
added
the
do-not-merge/hold
Contributor
Author
|
I'll do it in a separate PR. /hold cancel |
google-prow-robot
removed
the
do-not-merge/hold
google-prow-robot
pushed a commit
to knative/test-infra
that referenced
this pull request
Jul 23, 2018
* Add update_licenses() to library.sh This function run `dep-collector` in the prow-tests container to update the licenses used by the project. For an example of usage see knative/serving#1649 * Prefer a system wide dep-collector over the one in the container.
adrcunha
added a commit
to knative/test-infra
that referenced
this pull request
Aug 6, 2018
* Add update_licenses() to library.sh This function run `dep-collector` in the prow-tests container to update the licenses used by the project. For an example of usage see knative/serving#1649 * Prefer a system wide dep-collector over the one in the container.
bbrowning
pushed a commit
to bbrowning/serving
that referenced
this pull request
Oct 5, 2018
We're consolidating the test infrastructure into a single place, so all repos get the same fixes, updates and new features. dep-collector was added to prow-tests image in knative/test-infra#22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're consolidating the test infrastructure into a single place, so all repos get the same fixes, updates and new features.
dep-collectorwas added to prow-tests image in knative/test-infra#22 and `update_licenses() in knative/test-infra#24Bonus: also remove
koas a dependency, since it's also already installed in prow-tests image.