Skip to content

Add dep-collector and licenseclassifier to prow-tests image #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
google-prow-robot merged 1 commit into from
Jul 21, 2018
Merged

Add dep-collector and licenseclassifier to prow-tests image #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions images/prow-tests/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ RUN docker-credential-gcr configure-docker
RUN apt-get install -y uuid-runtime # for uuidgen
RUN go get github.com/google/go-containerregistry/cmd/ko
RUN go get github.com/golang/dep/cmd/dep
RUN go get github.com/mattmoor/dep-collector
Copy link
Copy Markdown
Contributor

@jessiezcc jessiezcc Jul 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattmoor , will dep-collector be merged into ko later?

Copy link
Copy Markdown
Member

@mattmoor mattmoor Jul 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's pretty orthogonal.

RUN go get github.com/google/licenseclassifier

# Add our scripts
ADD scripts/library.sh .
Expand Down