Ignore non-connected databases from search with Browser Integration #1810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varjolintu
changed the title
|
Rebase this onto 2.3.2 please. Although when you do that you will have to use the attributes instead of database custom data. |
|
I will make the needed modification to the custom data PR after this has been merged. |
varjolintu
force-pushed
the
search_all_fix
branch
from
7547fe2 to
4ff6236
Compare
varjolintu
force-pushed
the
search_all_fix
branch
from
4ff6236 to
97452d0
Compare
droidmonkey
approved these changes
Apr 6, 2018
droidmonkey
added a commit
that referenced
this pull request
May 8, 2018
- Enable high entropy ASLR on Windows [#1747] - Enhance favicon fetching [#1786] - Fix crash on Windows due to autotype [#1691] - Fix dark tray icon changing all icons [#1680] - Fix --pw-stdin not using getPassword function [#1686] - Fix placeholders being resolved in notes [#1907] - Enable auto-type start delay to be configurable [#1908] - Browser: Fix native messaging reply size [#1719] - Browser: Increase maximum buffer size [#1720] - Browser: Enhance usability and functionality [#1810, #1822, #1830, #1884, #1906] - SSH Agent: Parse aes-256-cbc/ctr keys [#1682] - SSH Agent: Enhance usability and functionality [#1677, #1679, #1681, #1787]
jtl999
pushed a commit
to jtl999/keepassxc
that referenced
this pull request
Jul 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignores non-connected databases if search from all databases option is enabled in Browser Integration settings.
Description
Previously searching from all databases returned entries also from non-connected databases, which is not very secure. This change only searches from databases that are connected with the browser extension. KeePassXC-Browser side change is needed, although it can be merged beforehand.
Motivation and context
KeePassXC-Browser side PR here: keepassxreboot/keepassxc-browser#108.
How has this been tested?
Manually.
Types of changes
Checklist:
-DWITH_ASAN=ON. [REQUIRED]