Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSH Agent: Fix wrong slot reference #1787

Merged

Conversation

luzat
Copy link
Contributor

@luzat luzat commented Mar 28, 2018

Fixes an error message and non-working functionality introduced by a
wrong slot referenced in PR #1679. Compare comments in PR.

Description

Fixed reference.

Motivation and context

The previous commit referred to a wrong slot and thus did not have any effect but producing an error. This probably happened because the wrong version was pushed into Git.

How has this been tested?

All tests have been repeated as for the original version, just this time pushed the correct version.

Fixes an error message and non-working functionality introduced by a
wrong slot referenced in PR keepassxreboot#1679.
@droidmonkey droidmonkey added this to the v2.3.2 milestone Apr 5, 2018
@droidmonkey droidmonkey added the bug label Apr 5, 2018
@droidmonkey droidmonkey merged commit d1c5a1a into keepassxreboot:release/2.3.2 Apr 5, 2018
droidmonkey added a commit that referenced this pull request May 8, 2018
- Enable high entropy ASLR on Windows [#1747]
- Enhance favicon fetching [#1786]
- Fix crash on Windows due to autotype [#1691]
- Fix dark tray icon changing all icons [#1680]
- Fix --pw-stdin not using getPassword function [#1686]
- Fix placeholders being resolved in notes [#1907]
- Enable auto-type start delay to be configurable [#1908]
- Browser: Fix native messaging reply size [#1719]
- Browser: Increase maximum buffer size [#1720]
- Browser: Enhance usability and functionality [#1810, #1822, #1830, #1884, #1906]
- SSH Agent: Parse aes-256-cbc/ctr keys [#1682]
- SSH Agent: Enhance usability and functionality [#1677, #1679, #1681, #1787]
jtl999 pushed a commit to jtl999/keepassxc that referenced this pull request Jul 29, 2018
Fixes an error message and non-working functionality introduced by a
wrong slot referenced in PR keepassxreboot#1679.
@phoerious phoerious added pr: bugfix Pull request that fixes a bug and removed bug labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: bugfix Pull request that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants