Fix wrong reply size in NativeMessagingBase #1719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Using length() on QString won't return correct size in bytes when string contains UTF-8 chars.
|
Rebased on release/2.3.2 |
phoerious
approved these changes
Mar 13, 2018
|
You could have just changed the target of the old PR. ;-) |
droidmonkey
added a commit
that referenced
this pull request
May 8, 2018
- Enable high entropy ASLR on Windows [#1747] - Enhance favicon fetching [#1786] - Fix crash on Windows due to autotype [#1691] - Fix dark tray icon changing all icons [#1680] - Fix --pw-stdin not using getPassword function [#1686] - Fix placeholders being resolved in notes [#1907] - Enable auto-type start delay to be configurable [#1908] - Browser: Fix native messaging reply size [#1719] - Browser: Increase maximum buffer size [#1720] - Browser: Enhance usability and functionality [#1810, #1822, #1830, #1884, #1906] - SSH Agent: Parse aes-256-cbc/ctr keys [#1682] - SSH Agent: Enhance usability and functionality [#1677, #1679, #1681, #1787]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NativeMessagingBase::sendReply send incorrectly formatted payload back to keepassxc-browser extension when using some locales.
Description
contains UTF-8 chars.
Motivation and context
This commit fix many bugs with keepassxc-browser when keepassxc locale is set to a language with chars represented by multiple bytes (UTF-8).
For instance, error string "Aucun identifiant trouvé" ("No logins found" in french) cause keepassxc-browser extension to disconnect from database.
How has this been tested?
This fix solves my issues in keepassxc-browser (firefox / chromium tested), with keepassxc in french.
Types of changes
Checklist:
-DWITH_ASAN=ON. [REQUIRED]