SSH Agent: Update available attachments immediately #1679
Conversation
|
Please rebase onto |
The list of available attachments for SSH agent is now updated immediately when adding or removing file attachments. Closes keepassxreboot#1668.
luzat
force-pushed
the
fix-agent-attachments
branch
from
d8dccf6 to
b28bf08
Compare
|
Not sure if I am doing this right: rebasing from |
|
Use the edit button next to the PR title to change the base branch. It's under the title in edit mode. |
|
The command line version is: |
|
Rebasing (and pushing) alone - which is what I did before - did not seem to update the state of where I want it to be merged here. |
| @@ -281,6 +281,8 @@ void EditEntryWidget::setupSSHAgent() | |||
| connect(m_sshAgentUi->decryptButton, SIGNAL(clicked()), SLOT(decryptPrivateKey())); | |||
| connect(m_sshAgentUi->copyToClipboardButton, SIGNAL(clicked()), SLOT(copyPublicKey())); | |||
|
|
|||
| connect(m_advancedUi->attachmentsWidget->entryAttachments(), SIGNAL(modified()), SLOT(updateAttachments())); | |||
There was a problem hiding this comment.
updateAttachments() should be updateSSHAgentAttachments()? I got the following error on the latest git:
QObject::connect: No such slot EditEntryWidget::updateAttachments()
QObject::connect: (receiver name: 'EditWidget')
QObject::connect: No such slot EditEntryWidget::updateAttachments()
QObject::connect: (receiver name: 'EditWidget')
There was a problem hiding this comment.
Confirmed and fixed in #1787 Must have forgotten to add the final version to the commit. Now works and does not give the error message and updates as expected.
Fixes an error message and non-working functionality introduced by a wrong slot referenced in PR keepassxreboot#1679.
Fixes an error message and non-working functionality introduced by a wrong slot referenced in PR #1679.
- Enable high entropy ASLR on Windows [#1747] - Enhance favicon fetching [#1786] - Fix crash on Windows due to autotype [#1691] - Fix dark tray icon changing all icons [#1680] - Fix --pw-stdin not using getPassword function [#1686] - Fix placeholders being resolved in notes [#1907] - Enable auto-type start delay to be configurable [#1908] - Browser: Fix native messaging reply size [#1719] - Browser: Increase maximum buffer size [#1720] - Browser: Enhance usability and functionality [#1810, #1822, #1830, #1884, #1906] - SSH Agent: Parse aes-256-cbc/ctr keys [#1682] - SSH Agent: Enhance usability and functionality [#1677, #1679, #1681, #1787]
Fixes an error message and non-working functionality introduced by a wrong slot referenced in PR keepassxreboot#1679.
phoerious
added
pr: new feature
Description
The list of available attachments for SSH agent is now updated
immediately when adding or removing file attachments.
Motivation and context
When adding or removing attachments, the list of available attachments was previously only updated after hitting
ApplyorOK.Closes #1668.
How has this been tested?
Built on Linux, ran tests and tried adding and removing files with previously empty and non-empty lists. Also checked if removing a selected file would lead to an error.
Types of changes
Checklist:
-DWITH_ASAN=ON. [REQUIRED]