Disable STDIN listening when not needed #1906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this not meant to cover Windows? Looks like it only applies to non-Windows hosts. |
|
Yes, this is only with platforms that can use QSocketNotifier with STDIN. |
phoerious
approved these changes
May 6, 2018
droidmonkey
requested changes
May 6, 2018
| @@ -77,6 +77,11 @@ void NativeMessagingHost::run() | |||
| QString serverPath = getLocalServerPath(); | |||
| QFile::remove(serverPath); | |||
|
|
|||
| // Ensure that STDIN is not being listened when proxy is used | |||
| if (m_notifier->isEnabled()) { | |||
| m_notifier->setEnabled(false); | |||
There was a problem hiding this comment.
Shouldn't this be handled by the base class?
There was a problem hiding this comment.
This is just a precaution. It handles a situation where proxy has been disabled but is enabled again.
weslly
approved these changes
May 6, 2018
droidmonkey
approved these changes
May 7, 2018
droidmonkey
added a commit
that referenced
this pull request
May 8, 2018
- Enable high entropy ASLR on Windows [#1747] - Enhance favicon fetching [#1786] - Fix crash on Windows due to autotype [#1691] - Fix dark tray icon changing all icons [#1680] - Fix --pw-stdin not using getPassword function [#1686] - Fix placeholders being resolved in notes [#1907] - Enable auto-type start delay to be configurable [#1908] - Browser: Fix native messaging reply size [#1719] - Browser: Increase maximum buffer size [#1720] - Browser: Enhance usability and functionality [#1810, #1822, #1830, #1884, #1906] - SSH Agent: Parse aes-256-cbc/ctr keys [#1682] - SSH Agent: Enhance usability and functionality [#1677, #1679, #1681, #1787]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STDIN is being listened even if the browser integration is disabled.
Description
Enables the listening by default for keepassxc-proxy, but for KeePassXC the STDIN will be listened only if proxy is disabled.
Motivation and context
Fixes #1574.
How has this been tested?
Manually.
Types of changes
Checklist:
-DWITH_ASAN=ON. [REQUIRED]