remove jq ready() when not needed

[dgrammatiko]

This removes some unneeded jQuery dependency on submit functions!

Test

apply patch and validate that form submission is working for administrator:
com_admin
com_banners
com_categories
com_contact
com_content
com_finder

[zero-24]

@DGT41

Component	Test result
com_admin	issue
com_banners	success
com_categories	success
com_contact	success
com_content	success
com_finder	success

Are the seach tools also in this PR?
I get there:
Uncaught TypeError: Cannot read property 'options' of null

• (anonymous function)
  • index.php?option=com_content&view=articles:62
• (anonymous function)
  • index.php?option=com_content&view=articles:74

com_admin:
Uncaught TypeError: undefined is not a function

• Joomla.submitbutton:
  • index.php?option=com_admin&view=profile&layout=edit&id=XXX:31
• onclick
  • index.php?option=com_admin&view=profile&layout=edit&id=XXX:172

[dgrammatiko]

@zero-24 Thanks!

[smanzi]

@test success for this PR
Tested the set of: #5046 #5048 #5049 #5050 #5051 #5052 #5053 #5054 #5056 #5058 #5113 #5255

[smanzi]

@DGT41 @phproberto I think we are all-set... right? This PR needs one more test: can you test it, Roberto?

[phproberto]

Please ensure that there is a semicolon after the closing bracket. If not we can have issues when all the declared scripts are merged.

[phproberto]

Still semicolon missing here and in the other finder files.

[dgrammatiko]

done

[ghazal]

In com_plugins,
com_plugins/views/plugin/tmpl/edit.php
Save and Save & close not working without :

jQuery(document).ready(function()
....

Should not it be this ?

        jQuery(document).ready(function() {
        Joomla.submitbutton = function(task)
    {
        if (task == 'plugin.cancel' || document.formvalidator.isValid(document.getElementById('style-form'))) {
            Joomla.submitform(task, document.getElementById('style-form'));
        }
    }
            });

[dgrammatiko]

@ghazal actually what is missing is a ; at the end. Thanks for finding this. #5273 takes care of it!

[dgrammatiko]

@anibalsanchez can you test this one?

[anibalsanchez]

com_admin OK
com_banners OK
com_categories OK
com_contact OK
com_content OK
com_finder Minor issue, the validator is allowing the form submission in Search Filters, and the mandatory field warning is caught server-side

[dgrammatiko]

I guess that validator failure is caused from the not working script in that page, but we have a PR for that: #5099

[anibalsanchez]

@test success,

Minor issue with finder can be solved here #5099.

[brianteeman]

Two good tests setting to RTc - thanks

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5255.

[wilsonge]

@DGT41 This looks similar to the PR that broke saving user notes (see #5363) can you confirm that you don't get the same issue here please?

[dgrammatiko]

@wilsonge Some insights:
administrator/components/com_admin/views/profile/tmpl/edit.php no text area, everything ok
administrator/components/com_banners/views/banner/tmpl/edit.php text area at description saves ok
administrator/components/com_banners/views/client/tmpl/edit.php text area at Additional Information saves ok
administrator/components/com_categories/views/category/tmpl/edit.php version note is not saved ??
administrator/components/com_contact/views/contact/tmpl/edit.php saves ok
administrator/components/com_content/views/article/tmpl/edit.php saves ok
administrator/components/com_finder ok

[dgrammatiko]

@wilsonge George I wanted to inform you that this pr solves a bug in profile edit (active right now on staging). There is a .id() where it should be .getElementById() here

[dgrammatiko]

@wilsonge I stated above that version note is not saved, but that is wrong! the note is saved (you can see it in content history modal) but I guess the reload of the form doesn’t take account of any existing value. So all clear here!

[wilsonge]

@test works fine here as well. Merging

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5255.}