Skip to content

[5.4] Convert mod_menu to service provider#45687

Merged
muhme merged 7 commits intojoomla:5.4-devfrom
joomlaweby:mod_menu
Jul 12, 2025
Merged

[5.4] Convert mod_menu to service provider#45687
muhme merged 7 commits intojoomla:5.4-devfrom
joomlaweby:mod_menu

Conversation

@joomlaweby
Copy link
Contributor

Summary of Changes

Converts the administrator menu module to service provider.

Testing Instructions

  1. Make sure you have administrator module mod_menu published and configured
  2. You should see module output

mod_menu

Actual result BEFORE applying this Pull Request

Module works as expected

Expected result AFTER applying this Pull Request

Module works same way as before applying pull request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@sergeytolkachyov
Copy link
Contributor

I have tested this item ✅ successfully on 9d8ec9a

Menu module works.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45687.

@exlemor
Copy link

exlemor commented Jul 11, 2025

I have tested this item ✅ successfully on 9d8ec9a

I have tested this successfully - even changed the menu to Alternative menu, turned off / on options everything worked as expected.

Thanks @joomlaweby!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45687.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45687.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 11, 2025
@muhme muhme merged commit 2eddaf4 into joomla:5.4-dev Jul 12, 2025
32 of 33 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 12, 2025
@muhme
Copy link
Contributor

muhme commented Jul 12, 2025

Thank you @joomlaweby and all testers.

@muhme muhme added this to the Joomla! 5.4.0 milestone Jul 12, 2025
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jul 12, 2025
muhme pushed a commit that referenced this pull request Jul 15, 2025
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jul 28, 2025
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 3, 2025
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 5, 2025
@brianteeman
Copy link
Contributor

See #45886 this PR results in a fatal error when creating admin menu modules not sure how it could have been tested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants