Skip to content

[5.4] Update deleted files in script.php for the upcoming 5.4.0-alpha3#45718

Merged
muhme merged 3 commits intojoomla:5.4-devfrom
richard67:5.4-dev-deleted-files-2025-07-12
Jul 15, 2025
Merged

[5.4] Update deleted files in script.php for the upcoming 5.4.0-alpha3#45718
muhme merged 3 commits intojoomla:5.4-devfrom
richard67:5.4-dev-deleted-files-2025-07-12

Conversation

@richard67
Copy link
Member

Pull Request for Issue # .

Summary of Changes

This pull request (PR) updates the list of files to be deleted on update in script.php to the latest changes in the 5.3-dev branch, which are the deleted files resulting from PRs #45648 and #45687 .

Testing Instructions

Compare a current 5.4-dev package or a 5.4 nightly build from last night with a 5.4.0-alpha2 package and check for files which exist only in the 5.4.0-alpha2 but not in current 5.4-dev or the latest 5.4 nightly build.

Update a 5.4.0-alpha2 to the latest 5.4 nightly build for the actual result, and update a 5.4.0-alpha2 to the patched update package or custom update URL created by drone for this PR for the expected result.

Actual result BEFORE applying this Pull Request

The files added by this PR to the list are still there after an update from 5.4.0-alpha2 to 5.4-dev nightly build, however they would not be there when making a new installation with that nightly build.

Expected result AFTER applying this Pull Request

The files added by this PR to the list are deleted after an update from 5.4.0-alpha2 to the patched package of this PR.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on b416850


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45718.

@travisrisner
Copy link
Contributor

I have tested this item ✅ successfully on b416850

@richard67
Copy link
Member Author

I have tested this item ✅ successfully on b416850

@travisrisner Just a comment with a green check mark is not counted by our tools. Could you mark your test result in the issue tracker by using the blue "Test this" button at the top left corner? Thanks in advance.

@travisrisner
Copy link
Contributor

I have tested this item ✅ successfully on b416850

@travisrisner Just a comment with a green check mark is not counted by our tools. Could you mark your test result in the issue tracker by using the blue "Test this" button at the top left corner? Thanks in advance.

Thanks Richard! Noted. I've done this on quite a few tests previously and don't know that I've been corrected yet. I'll utilize the issue tracker going forward and fix this one.

@travisrisner
Copy link
Contributor

I have tested this item ✅ successfully on b416850


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45718.

@richard67
Copy link
Member Author

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45718.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 15, 2025
@muhme
Copy link
Contributor

muhme commented Jul 15, 2025

✅ Re-Check after upmerge from 5.3-dev with current 5.4-dev and before merge:

git diff --name-status 5.4.0-alpha2..HEAD | grep '^D'

The result is exactly the two added files:

D	administrator/modules/mod_menu/mod_menu.php
D	modules/mod_random_image/mod_random_image.php

@muhme muhme merged commit 0939357 into joomla:5.4-dev Jul 15, 2025
32 of 34 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 15, 2025
@muhme muhme added this to the Joomla! 5.4.0 milestone Jul 15, 2025
@muhme
Copy link
Contributor

muhme commented Jul 15, 2025

Thank you @richard67 and all testers.

@richard67 richard67 deleted the 5.4-dev-deleted-files-2025-07-12 branch July 15, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants