[5.4] Use database from container and fix menuType table instantiation

[richard67]

Pull Request for Issue #45886 .

Summary of Changes

This pull request (PR) fixes a regression which was introduced in 5.4.0-alpha3 and 6.0.0-alpha3 with PR #45687 .

Thanks to @HLeithner for suggestions on how to fix it.

Testing Instructions

Copied from issue #45886 :

• Enable debug (so that you will get the bug stack trace)
• In the admin create a new admin menu - no need to create any items
• Click on add module and publish the module in the menu position
• Click on any item in the menu

Actual result BEFORE applying this Pull Request

See issue #45886 .

Expected result AFTER applying this Pull Request

Menu item opens.

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[brianteeman]

seems to have the same problem

[richard67]

seems to have the same problem

@brianteeman My mistake, use statement for the Factory is missing.

[brianteeman]

yes that works

[brianteeman]

I have tested this item ✅ successfully on bcebe72

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45890.}

[richard67]

@brianteeman Could you test again? That would be great. Thanks in advance.

[dautrich]

I have tested this item ✅ successfully on fffe775

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45890.}

[brianteeman]

I have tested this item ✅ successfully on fffe775

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45890.}

[richard67]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45890.}

[muhme]

✅ Final Test before merge

• Seen the 500 'Call to a member function load() on false'
• JBT graft full package, tested issue is fixed, tested all positions