[5.4] Convert mod_whosonline to service provider#45775
Conversation
|
I have tested this item ✅ successfully on 886678d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45775. |
1 similar comment
|
I have tested this item ✅ successfully on 886678d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45775. |
|
I have tested this item ✅ successfully on 886678d (Unrelated to this PR but Heiko and I discovered a potential bug or at least odd behavior in Safari 18.x+ with the Who's Online module (with or without the PR applied) where if you reload the front-end page it increments by 1 the number of Who's Online guests even though there is still just you browsing the site - it may be because of a protective feature of Safari..) Interestingly, (I checked the database) while the session_id is different each time the 820 byte data that is in the data field is IDENTICAL. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45775. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45775. |
|
Final test before merge, before applying this PR, with JBT graft Joomla_5.4.0-alpha4-dev-Development-Full_Package.zip:
Tested with this PR by graft Joomla_5.4.0-alpha4-dev+pr.45775-Development-Full_Package.zip:
|
|
Thank you @joomlaweby for your contribution. Thank you @ghazal, @hans2103 and @exlemor for testing. |
Summary of Changes
Converts the who is online site module to service provider.
Testing Instructions
Actual result BEFORE applying this Pull Request
Module works as expected
Expected result AFTER applying this Pull Request
Module works same way as before applying pull request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed