Skip to content

[5.4] Convert mod_whosonline to service provider#45775

Merged
muhme merged 4 commits intojoomla:5.4-devfrom
joomlaweby:mod_whoisonline
Jul 26, 2025
Merged

[5.4] Convert mod_whosonline to service provider#45775
muhme merged 4 commits intojoomla:5.4-devfrom
joomlaweby:mod_whoisonline

Conversation

@joomlaweby
Copy link
Contributor

Summary of Changes

Converts the who is online site module to service provider.

Testing Instructions

  1. Make sure you have site module mod_whosonline published
  2. You should see module output
mod_whosonline

Actual result BEFORE applying this Pull Request

Module works as expected

Expected result AFTER applying this Pull Request

Module works same way as before applying pull request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@ghazal
Copy link
Contributor

ghazal commented Jul 25, 2025

I have tested this item ✅ successfully on 886678d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45775.

1 similar comment
@hans2103
Copy link
Contributor

I have tested this item ✅ successfully on 886678d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45775.

@exlemor
Copy link

exlemor commented Jul 25, 2025

I have tested this item ✅ successfully on 886678d

I have successfully tested this on Chrome, Firefox, Safari.

(Unrelated to this PR but Heiko and I discovered a potential bug or at least odd behavior in Safari 18.x+ with the Who's Online module (with or without the PR applied) where if you reload the front-end page it increments by 1 the number of Who's Online guests even though there is still just you browsing the site - it may be because of a protective feature of Safari..)

Interestingly, (I checked the database) while the session_id is different each time the 820 byte data that is in the data field is IDENTICAL.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45775.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45775.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 25, 2025
@muhme
Copy link
Contributor

muhme commented Jul 26, 2025

Final test before merge, before applying this PR, with JBT graft Joomla_5.4.0-alpha4-dev-Development-Full_Package.zip:

  • Tested to display '# of Guests / Users', 'Usernames' and 'Both'

Tested with this PR by graft Joomla_5.4.0-alpha4-dev+pr.45775-Development-Full_Package.zip:

  • ✅ Tested to display '# of Guests / Users', 'Usernames' (with no one logged in -> empty and one login) and 'Both'
  • Installed German language paket as extension and switched to default German
  • ✅ Tested to display Who's Online with German translations

@muhme muhme merged commit c6a929e into joomla:5.4-dev Jul 26, 2025
34 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 26, 2025
@muhme muhme added this to the Joomla! 5.4.0 milestone Jul 26, 2025
@muhme
Copy link
Contributor

muhme commented Jul 26, 2025

Thank you @joomlaweby for your contribution. Thank you @ghazal, @hans2103 and @exlemor for testing.

richard67 added a commit to richard67/joomla-cms that referenced this pull request Jul 28, 2025
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jul 28, 2025
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jul 29, 2025
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 3, 2025
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 3, 2025
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 4, 2025
muhme pushed a commit that referenced this pull request Aug 4, 2025
…#45832)

* Add deleted files from PRs #45762 and #45775
* Add deleted files from PRs #45801 , #45807 and #45815
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants