[5.3] Don't use the deprecated CMS Filesystem but the framework package in package installer

[richard67]

Pull Request for Issue # .

Summary of Changes

This pull request (PR) changes the package installer plugin ("System" -> "Install" -> "Extensions", tab "Upload Package File") to use the filesystem package from the framework instead of the deprecated CMS filesystem package to determine the maximum file upload size from php.ini settings "post_max_size" and "upload_max_filesize".

That's one of the 2 places where we currently use the deprecated package in the 5.3-dev branch and up.

I've decided to use an alias for the helper, use Joomla\Filesystem\Helper as FilesystemHelper, because it seems odd to me to use just Helper in the plugin code, which could readers may think that the helper belongs to that plugin.

If maintainers decide this to be an enhancement or new feature which comes too late for 5.3.0 and should not be made later with 5.3 patch versions, I will rebase this PR to 5.4-dev.

Testing Instructions

This PR requires the dependency update PR which was merged yesterday. See also #45071 (comment) .

In the administrator, go to "System" -> "Install" -> "Extensions", tab "Upload Package File", and note the "Maximum upload size" shown below the "Or browse for file" button is correct.

Apply the patch and go again to "System" -> "Install" -> "Extensions", tab "Upload Package File", or reload the page if still there.

Actual result BEFORE applying this Pull Request

"Maximum upload size" is shown below the "Or browse for file" button.

Expected result AFTER applying this Pull Request

"Maximum upload size" is shown below the "Or browse for file" button. The value is the same as without the PR.

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[exlemor]

Hello Richard,

I am getting:

An error has occurred.
0 Call to undefined method Joomla\Filesystem\Helper::getFileUploadMaxSize()
Return to Dashboard

--- on 5.3 ßeta 2, on PHP 8.3.19, MariaDB 10.6.15

[richard67]

You have to test the PR on a current 5.3-dev branch which includes the dependency update which was merged yesterday.

[richard67]

P.S.: A nightly build from tonight should also work.

See also #45071 (comment) .

[exlemor]

I have tested this item ✅ successfully on 393104c

I was able to test this successfully!

Thx @richard67!

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45139.}

[richard67]

@exlemor Thanks for testing.

[exlemor]

Thank you @richard67 for the help along the way ;)

[richard67]

Well I simply had forgotten to mention it in the testing instructions. Is meanwhile added.

[alikon]

I have tested this item ✅ successfully on 393104c

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45139.}

[alikon]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45139.}

[laoneo]

Thanks!