Skip to content

[5.3][webservices] not found without Warning#45132

Merged
rdeutz merged 4 commits intojoomla:5.3-devfrom
alikon:patch-20
Mar 21, 2025
Merged

[5.3][webservices] not found without Warning#45132
rdeutz merged 4 commits intojoomla:5.3-devfrom
alikon:patch-20

Conversation

@alikon
Copy link
Contributor

@alikon alikon commented Mar 14, 2025

Pull Request for Issue # .

Summary of Changes

check false when an item don't exist

Testing Instructions

do a GET for a not existent item api/index.php/v1/content/articles/134534

Actual result BEFORE applying this Pull Request

php warning PHP Warning: Attempt to read property "id" on false in /var/www/html/libraries/src/MVC/View/JsonApiView.php on line 218

Expected result AFTER applying this Pull Request

no more warning

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@alikon alikon marked this pull request as ready for review March 14, 2025 16:16
@laoneo
Copy link
Member

laoneo commented Mar 14, 2025

I have tested this item ✅ successfully on 65e4f8b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45132.

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 65e4f8b

code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45132.

@alikon
Copy link
Contributor Author

alikon commented Mar 14, 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45132.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 14, 2025
@rdeutz rdeutz merged commit 39b88d1 into joomla:5.3-dev Mar 21, 2025
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 21, 2025
@rdeutz rdeutz added this to the Joomla! 5.3.0 milestone Mar 21, 2025
@rdeutz
Copy link
Contributor

rdeutz commented Mar 21, 2025

Thanks

@alikon alikon deleted the patch-20 branch March 21, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants