php 8.4 Implicitly nullable parameter declarations deprecated#3
Merged
SniperSister merged 1 commit intojoomla-backports:joomla-backportsfrom Mar 21, 2025
Merged
Conversation
tested by running the joomla integration tests with php 8.4 `npx cypress run --spec '.\tests\System\integration\api\com_config\'` This pr fixes the deprecation notice [19-Mar-2025 21:55:34 UTC] PHP Deprecated: Tobscure\JsonApi\AbstractSerializer::getAttributes(): Implicitly marking parameter $fields as nullable is deprecated, the explicit nullable type must be used instead in D:\repos\j51\libraries\vendor\tobscure\json-api\src\AbstractSerializer.php on line 44 [19-Mar-2025 21:55:34 UTC] PHP Deprecated: Tobscure\JsonApi\SerializerInterface::getAttributes(): Implicitly marking parameter $fields as nullable is deprecated, the explicit nullable type must be used instead in D:\repos\j51\libraries\vendor\tobscure\json-api\src\SerializerInterface.php on line 42 [19-Mar-2025 21:55:35 UTC] PHP Deprecated: Tobscure\JsonApi\AbstractSerializer::getAttributes(): Implicitly marking parameter $fields as nullable is deprecated, the explicit nullable type must be used instead in D:\repos\j51\libraries\vendor\tobscure\json-api\src\AbstractSerializer.php on line 44 [19-Mar-2025 21:55:35 UTC] PHP Deprecated: Tobscure\JsonApi\SerializerInterface::getAttributes(): Implicitly marking parameter $fields as nullable is deprecated, the explicit nullable type must be used instead in D:\repos\j51\libraries\vendor\tobscure\json-api\src\SerializerInterface.php on line 42
laoneo
approved these changes
Mar 21, 2025
|
Thank you @brianteeman ! |
|
@brianteeman can you make an update pr in the CMS repo? |
brianteeman
added a commit
to brianteeman/joomla-cms
that referenced
this pull request
Mar 21, 2025
joomla-backports/json-api-php#3 Fixes deprecation notices Signed-off-by: BrianTeeman <brian@teeman.net>
Author
laoneo
pushed a commit
to joomla/joomla-cms
that referenced
this pull request
Mar 22, 2025
joomla-backports/json-api-php#3 Fixes deprecation notices Signed-off-by: BrianTeeman <brian@teeman.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tested by running the joomla integration tests with php 8.4
npx cypress run --spec '.\tests\System\integration\api\com_config\'This pr fixes the deprecation notice