[5.3] Remove non-distributed files

[brianteeman]

During the build process of a new release or update we remove various files that should not or do not need to be distributed

This PR extends the list of files to be removed from the libraries/vendor folder to include

.drone.yml
.drone.jsonnet

Examples can be seen in most of the libraries/vendor/joomla folders

@richard67 I assume that this will need to be added to the removed files list

[exlemor]

Hi @brianteeman, is there perhaps a missing label for this PR, I just tried testing it and Joomla Patch Tester said:

There are no files to patch from this pull request. This may mean that the files in the pull request are not present in your installation.

and the .drone.yml, .drone.jsonnet files were still present in the sub-folders..

(which led me to think, it perhaps should require a Download - Prebuilt package?)

[brianteeman]

@exlemor as stated in the PR this is in the script to build a release. it is not in the release of joomla

[ghost]

@exlemor Look in tab "Files changed", if the file is not in path "/administrator/..." its not able to test by patchtester, prebuilt packages.

[exlemor]

@exlemor Look in tab "Files changed", if the file is not in path "/administrator/..." its not able to test by patchtester, prebuilt packages.

Probably obvious but not something I knew, great insight - thanks @fgsw

[richard67]

@richard67 I assume that this will need to be added to the removed files list

@brianteeman Correct. I will handle that regularly and so add them when this PR has been merged.

[brianteeman]

@exlemor Look in tab "Files changed", if the file is not in path "/administrator/..." its not able to test by patchtester, prebuilt packages.

Probably obvious but not something I knew, great insight - thanks @fgsw

not true as obviously changes in /plugins/ for example can be tested

[brianteeman]

@richard67 I assume that this will need to be added to the removed files list

@brianteeman Correct. I will handle that regularly and so add them when this PR has been merged.

thanks

[richard67]

@exlemor Testing instructions: Download the full installation zip package created by Drone for this PR, and download a recent 5.3 nightly build, and compare the content of the 2 zip files regarding files which only exist in the nightly build package but not in the one for this PR.

Package for this PR: https://artifacts.joomla.org/drone/joomla/joomla-cms/5.3-dev/45152/downloads/83435/Joomla_5.3.0-beta3-dev+pr.45152-Development-Full_Package.zip

Nightly build: https://developer.joomla.org/nightlies/Joomla_5.3.0-beta3-dev-Development-Full_Package.zip

Result:

The comparison tool (Beyond Compare) shows the package of this PR on the left hand side and the package from the nightly build at the right hand side. It is adjusted to only show singles on the right hand side, i.e. only the files which exists on the right hand side but not at the left hand side. Other differences are not shown in this mode.

As you can see, the PR does what it claims to do.

[richard67]

I have tested this item ✅ successfully on da9b83f

Details about how I've tested see my previous comment.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45152.}

[exlemor]

I have tested this item ✅ successfully on da9b83f

I was able to successfully test this (thanks to @richard67's help).

I used an alternative to BeyondCompare.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45152.}

[QuyTon]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45152.}

[laoneo]

Thanks!

[brianteeman]

Thanks