Skip to content

Conversation

@tecpromotion
Copy link
Contributor

Pull Request for PR #44813

Summary of Changes

fix language changes in PR #44813

Testing Instructions

code review

Actual result BEFORE applying this Pull Request

The language strings are not sorted alphabetically.

Expected result AFTER applying this Pull Request

The language strings are sorted alphabetically.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-5.3-dev labels Feb 7, 2025
Comment on lines 7 to 10
PLG_SYSTEM_JOOA11Y_FIELD_CHECKS="Turn Off Checks"
PLG_SYSTEM_JOOA11Y_FIELD_CHECKS_DESC="Turn off specific checks by key name. Learn how to <a href=\"https://sa11y.netlify.app/joomla/#turn-off-checks\" target=\"_blank\" rel=\"noopener noreferrer\">Turn Off Checks</a>."
PLG_SYSTEM_JOOA11Y_FIELD_CHECK_ROOT="Target Area to Check"
PLG_SYSTEM_JOOA11Y_FIELD_CHECK_ROOT_DESC="Input a single selector to target a specific region of your website. The default setting is the landmark <strong>main</strong>. Alternatives to landmarks are classes, elements or ARIA roles (e.g. #main-content, .main, [role='main']). Input <strong>body</strong> to check the entire page."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, underscores should come before letters. See tecpromotion#2 .

@richard67 richard67 added the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Feb 8, 2025
[CMS PPR 44839] Underscore before letters
@richard67 richard67 removed the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Feb 8, 2025
@richard67 richard67 merged commit b9e6129 into joomla:5.3-dev Feb 8, 2025
3 checks passed
@richard67
Copy link
Member

Merged by review.

@richard67 richard67 added this to the Joomla! 5.3.0 milestone Feb 8, 2025
@richard67
Copy link
Member

Thanks.

@tecpromotion tecpromotion deleted the issue/issue-alpha-storing-plg_system_jooa11y branch February 8, 2025 14:13
@brianteeman
Copy link
Contributor

This is wrong. Underscore has a higher asci value than all uppercase letters and therefore is always sorted after and not before

@richard67
Copy link
Member

This is wrong. Underscore has a higher asci value than all uppercase letters and therefore is always sorted after and not before

@brianteeman Could you make a PR? Was possibly my mistake.

@ghost
Copy link

ghost commented Feb 8, 2025

developer.joomla.org: "The strings should be alphabetically ordered using the "Standard Alphabetical Order" and not the "ASCII order". This mostly means here that the underscore is sorted BEFORE the letters."

@richard67
Copy link
Member

Well that's what I did with my PR for this PR. I've used notepad++, selected the lines and used line operation "Sort alphabetically ascending, ignore case".

@chmst
Copy link
Contributor

chmst commented Feb 8, 2025

This is wrong. Underscore has a higher asci value than all uppercase letters and therefore is always sorted after and not before

We have this also in other .ini files. Underscore before letters.

Kostelano added a commit to JPathRu/localisation that referenced this pull request Apr 14, 2025
joomla/joomla-cms#41496 - (upmerge с 5.2х)
joomla/joomla-cms#42530 +
joomla/joomla-cms#43994 - (upmerge с 5.2х)
joomla/joomla-cms#44009 - (upmerge с 5.2х)
joomla/joomla-cms#44010 - (upmerge с 5.2х)
joomla/joomla-cms#44161 +
joomla/joomla-cms#44187 - (upmerge с 5.2х)
joomla/joomla-cms#44207 - (upmerge с 5.2х)
joomla/joomla-cms#44271 +
joomla/joomla-cms#44273 +
joomla/joomla-cms#44288 - (только для en-GB)
joomla/joomla-cms#44348 - (upmerge с 5.2х)
joomla/joomla-cms#44366 +
joomla/joomla-cms#44367 - (upmerge с 5.2х)
joomla/joomla-cms#44434 - (upmerge с 5.2х)
joomla/joomla-cms#44448 - (upmerge с 5.2х)
joomla/joomla-cms#44462 +
joomla/joomla-cms#44487 - (upmerge с 5.2х)
joomla/joomla-cms#44587 +
joomla/joomla-cms#44600 +
joomla/joomla-cms#44604 +
joomla/joomla-cms#44621 - (upmerge с 5.2х)
joomla/joomla-cms#44623 +
joomla/joomla-cms#44632 +
joomla/joomla-cms#44640 - (позже был REVERT joomla/joomla-cms#44845)
joomla/joomla-cms#44714 - (upmerge с 5.2х)
joomla/joomla-cms#44756 +
joomla/joomla-cms#44768 - (upmerge с 5.2х)
joomla/joomla-cms#44792 - (только для en-GB)
joomla/joomla-cms#44813 +
joomla/joomla-cms#44822 - (upmerge с 5.2х)
joomla/joomla-cms#44839 +
joomla/joomla-cms#44871 +
joomla/joomla-cms#44954 +
joomla/joomla-cms#45034 - (upmerge с 5.2х)
joomla/joomla-cms#45058 - (только для en-GB)
joomla/joomla-cms#45064 +
joomla/joomla-cms#45078 - (только для en-GB)
joomla/joomla-cms#45130 - (upmerge с 5.2х)
joomla/joomla-cms#45240 - (upmerge с 5.2х)
joomla/joomla-cms#45246 - (только для др. пакетов)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language Change This is for Translators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants