[5.3] Customfields: Also look at context when checking uniqueness

[Hackwar]

Pull Request for Issue #44154 .

Summary of Changes

Customfields should only be uniquely named per context, so you should be able to have a field test in both articles and users. So far this is prohibited and you can only name a field uniquely system wide. This PR should fix that.

Testing Instructions

Create a customfield with name test in articles and in users.

Actual result BEFORE applying this Pull Request

Creating the second field is denied.

Expected result AFTER applying this Pull Request

Both fields can be saved.

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[brianteeman]

The error message needs to be updated as currently it says
COM_FIELDS_ERROR_UNIQUE_NAME="Another Field has the same name (remember it may be a trashed item or it may be already present as a custom field in another extension)."

It can now be simplified and made more consistent with other strings eg
COM_FIELDS_ERROR_UNIQUE_NAME="Another Field has the same name (remember it may be a trashed item)."

[ghost]

I have tested this item ✅ successfully on 58ccfe1

Test same Field name on

• Content
  • Articles
  • Category
• Contact
  • Contact
  • Mail
  • Category
• Users

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44161.}

[BertaOctech]

I have tested this item ✅ successfully on 58ccfe1

I tried to create a custom field in Content and Users with the same name.
It was not possible until I applied the patch.
Later on I used both the user field and the content field and each one kept its value and appeared in the correct place.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44161.}

[laoneo]

@Hackwar can you also change the text in the mentioned string from @brianteeman?

[Hackwar]

Done

[Quy]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44161.}

[laoneo]

Thanks!

[laoneo]

Just for reference, this one has been reverted with #44462. Should probably be implemented in 6.0.