Skip to content

[5.3] Loadmodule plugin remove unused options#44273

Merged
rdeutz merged 2 commits intojoomla:5.3-devfrom
brianteeman:loadmodule
Oct 17, 2024
Merged

[5.3] Loadmodule plugin remove unused options#44273
rdeutz merged 2 commits intojoomla:5.3-devfrom
brianteeman:loadmodule

Conversation

@brianteeman
Copy link
Contributor

@brianteeman brianteeman commented Oct 16, 2024

This simple PR removes two options from the loadmodule plugin which have not done anything since 4.0 as they are for module chromes that have not existed since 3.x

I marked the language strings as deprecated as i think that is the requirement although they can probably just be deleted now. That's a maintainer decision

Testing Instructions

code review

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

This simple PR removes two options from the loadmodule plugin which have not done anything since 4.0 as they arew for module chromes that have not existed since 3.x

I marked the language strings as deprecated as _i think_ that is the requirement although they can probably just be deleted now. Thats a maintainer decision

Signed-off-by: BrianTeeman <brian@teeman.net>
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-5.3-dev labels Oct 16, 2024
@Quy
Copy link
Contributor

Quy commented Oct 16, 2024

I have tested this item ✅ successfully on 382cab6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44273.

1 similar comment
@alikon
Copy link
Contributor

alikon commented Oct 16, 2024

I have tested this item ✅ successfully on 382cab6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44273.

@alikon
Copy link
Contributor

alikon commented Oct 16, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44273.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 16, 2024
@rdeutz rdeutz merged commit fd97303 into joomla:5.3-dev Oct 17, 2024
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 17, 2024
@rdeutz
Copy link
Contributor

rdeutz commented Oct 17, 2024

Thanks

@LadySolveig LadySolveig added this to the Joomla! 5.3.0 milestone Oct 17, 2024
@brianteeman
Copy link
Contributor Author

thx

@brianteeman brianteeman deleted the loadmodule branch October 17, 2024 09:16
Kostelano added a commit to JPathRu/localisation that referenced this pull request Apr 14, 2025
joomla/joomla-cms#41496 - (upmerge с 5.2х)
joomla/joomla-cms#42530 +
joomla/joomla-cms#43994 - (upmerge с 5.2х)
joomla/joomla-cms#44009 - (upmerge с 5.2х)
joomla/joomla-cms#44010 - (upmerge с 5.2х)
joomla/joomla-cms#44161 +
joomla/joomla-cms#44187 - (upmerge с 5.2х)
joomla/joomla-cms#44207 - (upmerge с 5.2х)
joomla/joomla-cms#44271 +
joomla/joomla-cms#44273 +
joomla/joomla-cms#44288 - (только для en-GB)
joomla/joomla-cms#44348 - (upmerge с 5.2х)
joomla/joomla-cms#44366 +
joomla/joomla-cms#44367 - (upmerge с 5.2х)
joomla/joomla-cms#44434 - (upmerge с 5.2х)
joomla/joomla-cms#44448 - (upmerge с 5.2х)
joomla/joomla-cms#44462 +
joomla/joomla-cms#44487 - (upmerge с 5.2х)
joomla/joomla-cms#44587 +
joomla/joomla-cms#44600 +
joomla/joomla-cms#44604 +
joomla/joomla-cms#44621 - (upmerge с 5.2х)
joomla/joomla-cms#44623 +
joomla/joomla-cms#44632 +
joomla/joomla-cms#44640 - (позже был REVERT joomla/joomla-cms#44845)
joomla/joomla-cms#44714 - (upmerge с 5.2х)
joomla/joomla-cms#44756 +
joomla/joomla-cms#44768 - (upmerge с 5.2х)
joomla/joomla-cms#44792 - (только для en-GB)
joomla/joomla-cms#44813 +
joomla/joomla-cms#44822 - (upmerge с 5.2х)
joomla/joomla-cms#44839 +
joomla/joomla-cms#44871 +
joomla/joomla-cms#44954 +
joomla/joomla-cms#45034 - (upmerge с 5.2х)
joomla/joomla-cms#45058 - (только для en-GB)
joomla/joomla-cms#45064 +
joomla/joomla-cms#45078 - (только для en-GB)
joomla/joomla-cms#45130 - (upmerge с 5.2х)
joomla/joomla-cms#45240 - (upmerge с 5.2х)
joomla/joomla-cms#45246 - (только для др. пакетов)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language Change This is for Translators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants