[5.3] Consistent Database Name Validation#44623
Merged
rdeutz merged 3 commits intojoomla:5.3-devfrom Jan 7, 2025
Merged
Conversation
Signed-off-by: BrianTeeman <brian@teeman.net>
Signed-off-by: BrianTeeman <brian@teeman.net>
richard67
reviewed
Dec 15, 2024
administrator/components/com_config/src/Model/ApplicationModel.php
Outdated
Show resolved
Hide resolved
richard67
reviewed
Dec 15, 2024
administrator/components/com_config/src/Model/ApplicationModel.php
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@richard67 appreciate the review but please leave it for me to approve/accept the changes |
|
I have tested this item ✅ successfully on aaa4f89
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44623. |
|
I have tested this item ✅ successfully on aaa4f89 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44623. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44623. |
Contributor
|
Thanks |
heelc29
added a commit
to heelc29/joomla
that referenced
this pull request
Feb 2, 2025
Kostelano
added a commit
to JPathRu/localisation
that referenced
this pull request
Apr 14, 2025
joomla/joomla-cms#41496 - (upmerge с 5.2х) joomla/joomla-cms#42530 + joomla/joomla-cms#43994 - (upmerge с 5.2х) joomla/joomla-cms#44009 - (upmerge с 5.2х) joomla/joomla-cms#44010 - (upmerge с 5.2х) joomla/joomla-cms#44161 + joomla/joomla-cms#44187 - (upmerge с 5.2х) joomla/joomla-cms#44207 - (upmerge с 5.2х) joomla/joomla-cms#44271 + joomla/joomla-cms#44273 + joomla/joomla-cms#44288 - (только для en-GB) joomla/joomla-cms#44348 - (upmerge с 5.2х) joomla/joomla-cms#44366 + joomla/joomla-cms#44367 - (upmerge с 5.2х) joomla/joomla-cms#44434 - (upmerge с 5.2х) joomla/joomla-cms#44448 - (upmerge с 5.2х) joomla/joomla-cms#44462 + joomla/joomla-cms#44487 - (upmerge с 5.2х) joomla/joomla-cms#44587 + joomla/joomla-cms#44600 + joomla/joomla-cms#44604 + joomla/joomla-cms#44621 - (upmerge с 5.2х) joomla/joomla-cms#44623 + joomla/joomla-cms#44632 + joomla/joomla-cms#44640 - (позже был REVERT joomla/joomla-cms#44845) joomla/joomla-cms#44714 - (upmerge с 5.2х) joomla/joomla-cms#44756 + joomla/joomla-cms#44768 - (upmerge с 5.2х) joomla/joomla-cms#44792 - (только для en-GB) joomla/joomla-cms#44813 + joomla/joomla-cms#44822 - (upmerge с 5.2х) joomla/joomla-cms#44839 + joomla/joomla-cms#44871 + joomla/joomla-cms#44954 + joomla/joomla-cms#45034 - (upmerge с 5.2х) joomla/joomla-cms#45058 - (только для en-GB) joomla/joomla-cms#45064 + joomla/joomla-cms#45078 - (только для en-GB) joomla/joomla-cms#45130 - (upmerge с 5.2х) joomla/joomla-cms#45240 - (upmerge с 5.2х) joomla/joomla-cms#45246 - (только для др. пакетов)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Pull Request for Issue #24291 .
Summary of Changes
Since 23704 the db name validation in the installer is stricter than the config component
Testing Instructions
In the global config options try to change the database name to something with a forbidden character eg for mysql add a \
Actual result BEFORE applying this Pull Request
Database connection test failed with the following error: 1049: Unknown database 'test_joomla'
Expected result AFTER applying this Pull Request
The database name is invalid. It must not contain the following characters: \ /
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed