Skip to content

[5.3] Consistent Database Name Validation#44623

Merged
rdeutz merged 3 commits intojoomla:5.3-devfrom
brianteeman:db_name_validate
Jan 7, 2025
Merged

[5.3] Consistent Database Name Validation#44623
rdeutz merged 3 commits intojoomla:5.3-devfrom
brianteeman:db_name_validate

Conversation

@brianteeman
Copy link
Contributor

Pull Request for Issue #24291 .

Summary of Changes

Since 23704 the db name validation in the installer is stricter than the config component

Testing Instructions

In the global config options try to change the database name to something with a forbidden character eg for mysql add a \

Actual result BEFORE applying this Pull Request

Database connection test failed with the following error: 1049: Unknown database 'test_joomla'

Expected result AFTER applying this Pull Request

The database name is invalid. It must not contain the following characters: \ /

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Signed-off-by: BrianTeeman <brian@teeman.net>
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-5.3-dev labels Dec 15, 2024
Signed-off-by: BrianTeeman <brian@teeman.net>
@brianteeman
Copy link
Contributor Author

@richard67 appreciate the review but please leave it for me to approve/accept the changes

@ghost
Copy link

ghost commented Dec 16, 2024

I have tested this item ✅ successfully on aaa4f89

Result BEFORE applying this Pull Request Result AFTER applying this Pull Request
Screen Shot 2024-12-16 at 08 13 30 Screen Shot 2024-12-16 at 08 22 14

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44623.

@ChristineWk
Copy link

I have tested this item ✅ successfully on aaa4f89


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44623.

@alikon
Copy link
Contributor

alikon commented Dec 16, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44623.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 16, 2024
@rdeutz rdeutz merged commit af3b32b into joomla:5.3-dev Jan 7, 2025
@rdeutz
Copy link
Contributor

rdeutz commented Jan 7, 2025

Thanks

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 7, 2025
@brianteeman brianteeman deleted the db_name_validate branch January 7, 2025 09:32
@rdeutz rdeutz added this to the Joomla! 5.3.0 milestone Jan 7, 2025
heelc29 added a commit to heelc29/joomla that referenced this pull request Feb 2, 2025
Kostelano added a commit to JPathRu/localisation that referenced this pull request Apr 14, 2025
joomla/joomla-cms#41496 - (upmerge с 5.2х)
joomla/joomla-cms#42530 +
joomla/joomla-cms#43994 - (upmerge с 5.2х)
joomla/joomla-cms#44009 - (upmerge с 5.2х)
joomla/joomla-cms#44010 - (upmerge с 5.2х)
joomla/joomla-cms#44161 +
joomla/joomla-cms#44187 - (upmerge с 5.2х)
joomla/joomla-cms#44207 - (upmerge с 5.2х)
joomla/joomla-cms#44271 +
joomla/joomla-cms#44273 +
joomla/joomla-cms#44288 - (только для en-GB)
joomla/joomla-cms#44348 - (upmerge с 5.2х)
joomla/joomla-cms#44366 +
joomla/joomla-cms#44367 - (upmerge с 5.2х)
joomla/joomla-cms#44434 - (upmerge с 5.2х)
joomla/joomla-cms#44448 - (upmerge с 5.2х)
joomla/joomla-cms#44462 +
joomla/joomla-cms#44487 - (upmerge с 5.2х)
joomla/joomla-cms#44587 +
joomla/joomla-cms#44600 +
joomla/joomla-cms#44604 +
joomla/joomla-cms#44621 - (upmerge с 5.2х)
joomla/joomla-cms#44623 +
joomla/joomla-cms#44632 +
joomla/joomla-cms#44640 - (позже был REVERT joomla/joomla-cms#44845)
joomla/joomla-cms#44714 - (upmerge с 5.2х)
joomla/joomla-cms#44756 +
joomla/joomla-cms#44768 - (upmerge с 5.2х)
joomla/joomla-cms#44792 - (только для en-GB)
joomla/joomla-cms#44813 +
joomla/joomla-cms#44822 - (upmerge с 5.2х)
joomla/joomla-cms#44839 +
joomla/joomla-cms#44871 +
joomla/joomla-cms#44954 +
joomla/joomla-cms#45034 - (upmerge с 5.2х)
joomla/joomla-cms#45058 - (только для en-GB)
joomla/joomla-cms#45064 +
joomla/joomla-cms#45078 - (только для en-GB)
joomla/joomla-cms#45130 - (upmerge с 5.2х)
joomla/joomla-cms#45240 - (upmerge с 5.2х)
joomla/joomla-cms#45246 - (только для др. пакетов)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language Change This is for Translators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants