Skip to content

[5][com_joomlaupdate] Deprecated: Creation of dynamic property php 8.2#41118

Merged
HLeithner merged 9 commits intojoomla:5.0-devfrom
alikon:patch-18
Aug 13, 2023
Merged

[5][com_joomlaupdate] Deprecated: Creation of dynamic property php 8.2#41118
HLeithner merged 9 commits intojoomla:5.0-devfrom
alikon:patch-18

Conversation

@alikon
Copy link
Contributor

@alikon alikon commented Jul 6, 2023

Pull Request for Issue # .

Summary of Changes

declare variables

Testing Instructions

set error report to maximum
go to Joomla Updatde
and / or php cli/joomla.php update:extensions:check

Actual result BEFORE applying this Pull Request

image

image

Expected result AFTER applying this Pull Request

no more deprecations

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@alikon alikon added the PHP 8.x PHP 8.x deprecated issues label Jul 6, 2023
@richard67 richard67 mentioned this pull request Jul 8, 2023
4 tasks
@HLeithner
Copy link
Member

doesn't this problem also exists in 4.3 and 4.4?

@alikon
Copy link
Contributor Author

alikon commented Aug 1, 2023

i didn't check, discovered when #41117

@HLeithner
Copy link
Member

can you please check and rebase for at least 4.4

@alikon alikon changed the base branch from 5.0-dev to 4.4-dev August 6, 2023 11:13
@alikon
Copy link
Contributor Author

alikon commented Aug 6, 2023

wrong rebase, i'll switch it back to 5

@alikon alikon changed the base branch from 4.4-dev to 5.0-dev August 6, 2023 11:14
@heelc29
Copy link
Contributor

heelc29 commented Aug 6, 2023

doesn't this problem also exists in 4.3 and 4.4?

I think it's only 5.x ...

#40999

@HLeithner
Copy link
Member

@alikon can I merge this or do you have further plans?

@alikon alikon marked this pull request as ready for review August 13, 2023 07:25
@alikon alikon requested review from rdeutz and zero-24 as code owners August 13, 2023 07:25
@alikon
Copy link
Contributor Author

alikon commented Aug 13, 2023

yes please, as long as i'll discover some more i'll do another pr

@HLeithner HLeithner merged commit fcd5290 into joomla:5.0-dev Aug 13, 2023
@HLeithner
Copy link
Member

thanks, I tested it and worked for me.

@HLeithner HLeithner added this to the Joomla! 5.0 milestone Aug 13, 2023
@alikon alikon deleted the patch-18 branch August 13, 2023 08:19
GeraintEdwards pushed a commit to GeraintEdwards/joomla-cms that referenced this pull request Aug 14, 2023
joomla#41118)

* Deprecated: Creation of dynamic property 8.2

* Deprecated: Creation of dynamic property

* update:extensions:check

* -redeclare

* noclueotherthan

---------

Co-authored-by: Harald Leithner <leithner@itronic.at>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PHP 8.x PHP 8.x deprecated issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants