Replaces the extension of CMSObject with the legacy traits#40999
Merged
HLeithner merged 11 commits intojoomla:5.0-devfrom Jun 26, 2023
Merged
Replaces the extension of CMSObject with the legacy traits#40999HLeithner merged 11 commits intojoomla:5.0-devfrom
HLeithner merged 11 commits intojoomla:5.0-devfrom
Conversation
laoneo
force-pushed
the
cmsobject/remove-extend
branch
from
8ad55ab to
bafc390
Compare
richard67
reviewed
Jun 21, 2023
Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
Member
|
thanks |
4 tasks
4 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Ongoing effort to get rid of
CMSObject. Replaced the classes which are extendingCMSObjectwith the legacy traits introduced in #39020. The BC break here is that checks which are for explicitCMSObjectwill fail, all the functionality is the same as these traits are used in theCMSObjectitself.Testing Instructions
Install 3rd party extensions and play with them.
Actual result BEFORE applying this Pull Request
All works.
Expected result AFTER applying this Pull Request
All works.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed