[5.0] fix joomla update not download url#41364
Merged
HLeithner merged 1 commit intojoomla:5.0-devfrom Aug 14, 2023
Merged
Conversation
Contributor
|
I have tested this item ✅ successfully on 2ddec12 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41364. |
Member
|
Thanks |
GeraintEdwards
pushed a commit
to GeraintEdwards/joomla-cms
that referenced
this pull request
Aug 14, 2023
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
property
downloadurlis protected since #41118 by @alikonso the check fails here now
joomla-cms/administrator/components/com_joomlaupdate/src/View/Joomlaupdate/HtmlView.php
Line 177 in 3fa34be
Testing Instructions
enter

Custom URLfor joomla update, for eg. of this pull requestclick on joomla update quickicon which shows that an update is available

Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select: