Skip to content

[5.0] fix joomla update not download url#41364

Merged
HLeithner merged 1 commit intojoomla:5.0-devfrom
heelc29:5.0/joomlaupdate-fix
Aug 14, 2023
Merged

[5.0] fix joomla update not download url#41364
HLeithner merged 1 commit intojoomla:5.0-devfrom
heelc29:5.0/joomlaupdate-fix

Conversation

@heelc29
Copy link
Contributor

@heelc29 heelc29 commented Aug 13, 2023

Summary of Changes

property downloadurl is protected since #41118 by @alikon

so the check fails here now

$hasDownload = isset($this->updateInfo['object']->downloadurl->_data);

Testing Instructions

enter Custom URL for joomla update, for eg. of this pull request
image

click on joomla update quickicon which shows that an update is available
image

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed

@alikon
Copy link
Contributor

alikon commented Aug 14, 2023

I have tested this item ✅ successfully on 2ddec12


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41364.

@HLeithner HLeithner merged commit 4a3859f into joomla:5.0-dev Aug 14, 2023
@HLeithner
Copy link
Member

Thanks

GeraintEdwards pushed a commit to GeraintEdwards/joomla-cms that referenced this pull request Aug 14, 2023
@heelc29 heelc29 deleted the 5.0/joomlaupdate-fix branch August 14, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants