Fixes notice about creating dynamic property currentUpdate on extension adapter#41324
Closed
roland-d wants to merge 1 commit intojoomla:5.0-devfrom
Closed
Fixes notice about creating dynamic property currentUpdate on extension adapter#41324roland-d wants to merge 1 commit intojoomla:5.0-devfrom
roland-d wants to merge 1 commit intojoomla:5.0-devfrom
Conversation
Signed-off-by: Roland Dalmulder <contact@rolandd.com>
Contributor
|
i've found some more on #41118 |
Contributor
Author
Contributor
|
@roland-d would you like to help me with declarations docs ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Add property
currentUpdateso it is not dynamically created.Testing Instructions
Deprecated: Creation of dynamic property Joomla\CMS\Updater\Adapter\ExtensionAdapter::$currentUpdate is deprecated in /var/www/html/joomla5.test/libraries/src/Updater/Adapter/ExtensionAdapter.php on line 57Actual result BEFORE applying this Pull Request
A notice is shown:
Expected result AFTER applying this Pull Request
Notice is gone.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed