Conversation
|
I have tested this item ✅ successfully on 46534b9 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41117. |
|
@alikon The PR fixes the "call to undefined method" PHP error. However, I still get following PHP notices shown at the command line: Am using PHP 8.1. I've tested with this PR and PR #41127 applied at the 4.4-dev branch and with a 5.0-dev update package which contain the changes of these 2 PRs plus the changes from PR #41118 , so I could be sure all other issues are fixed also after the update. You can find such a package here https://test5.richard-fath.de/Joomla_5.0.0-alpha3-dev-Development-Update_Package_2023-07-10_test-prs-41117-41127-41118.zip , and you can use the custom update URL https://test5.richard-fath.de/next_major_list_test-prs-41117-41127-41118.xml to update to that package. The issue seems to happen when the script.php which is already the updated one from 5.0-dev uninstalls the obsolete demo tasks plugin. The necessary fix might be somewhere in the extensions installer and might be similar to the fix you have applied in the InstallerHelper.php file here in this PR. |
|
i can confirm your findings, still looking for the root cause... |
|
it's still draft but... worth a review |
|
@alikon what is the status of this PR? |
|
@MacJoom thanks |
* Fix Indirect Modification of Overloaded Property * file_exists ---------
Pull Request for Issue #41115 .
Summary of Changes
Testing Instructions
update to 5.0 from 4.4 from cli
Actual result BEFORE applying this Pull Request
error/warning/notice
Expected result AFTER applying this Pull Request
update complete with success

Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed