[4.3] Accessibility Features Plugin: choice of two icon images (Google Font) #39614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating 4.3-dev with changes from 4.2-dev
…ents models (joomla#38090) * Replace Factory::getUser() by $this->getCurrentUser()
# Conflicts: # administrator/language/en-GB/install.xml # administrator/language/en-GB/langmetadata.xml # administrator/manifests/files/joomla.xml # administrator/manifests/packages/pkg_en-GB.xml # api/language/en-GB/install.xml # api/language/en-GB/langmetadata.xml # installation/language/en-GB/langmetadata.xml # language/en-GB/install.xml # language/en-GB/langmetadata.xml # libraries/src/Version.php
Merge branch 4.2 into 4.3
# Conflicts: # .gitignore # administrator/language/en-GB/install.xml # administrator/language/en-GB/langmetadata.xml # administrator/manifests/files/joomla.xml # administrator/manifests/packages/pkg_en-GB.xml # api/language/en-GB/install.xml # api/language/en-GB/langmetadata.xml # installation/language/en-GB/langmetadata.xml # language/en-GB/install.xml # language/en-GB/langmetadata.xml # libraries/src/Version.php
Upmerge 2022 09 03
Updating 4.3-dev with changes from 4.2-dev
If the user registration is not active, the menu item redirects to the login form. No message appears why the registration form is not displayed. Co-authored-by: Allon Moritz <[email protected]>
Updating 4.3-dev with changes from 4.2-dev
deleted return
Co-authored-by: Dimitris Grammatikogiannis <[email protected]>
Extension options
Extension options
Extension options
sandewt
requested review from
HLeithner,
Hackwar,
bembelimen,
chmst,
laoneo,
rdeutz,
wilsonge and
zero-24
as code owners
sandewt
changed the title
Contributor
Author
|
Did I do something wrong when creating this PR ??? |
Member
|
@sandewt It looks as if your branch for this PR is not based on the 4.2-dev branch for which the PR is made. Or did you want to make the PR for 4.3-dev? In this case you have made the PR for the wrong branch because it is made for the 4.2-dev branch. |
Contributor
Author
|
I think so too. I probably didn't create this PR for 4.3 properly, which was the intention. |
Contributor
|
@drmenzelit what is the state of the plugin? This PR seems to be in conflict with the current state |
Contributor
Author
Something went wrong while creating this PR. |
Contributor
Author
|
New pr #39615. [EDIT] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
32 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #38832 .
Summary of Changes
Testing Instructions
Actual result BEFORE applying this Pull Request
No option to choose an icon with a shape (Google Font)
Expected result AFTER applying this Pull Request
Some notes
See links:
It has not researched of the "package": "accessibility", "version": "3.0.17" is still correct.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed