Add ldap tests #38593
Merged
Add ldap tests #38593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HLeithner
reviewed
Aug 25, 2022
HLeithner
reviewed
Aug 25, 2022
HLeithner
reviewed
Aug 25, 2022
Contributor
Author
|
Now it also works on appveyor, thanks to the bitnami team, who accepted my PRs for their openldap image to include more logging so I could find the problem and to fix running as windows Administrator. |
Member
|
@Hackwar can you have a look and merge it afterwards? I update the drone signature already |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for missing LDAP tests as mentioned by @HLeithner in #37962 .
Summary of Changes
Testing Instructions
run the unit tests with #38421 applied (or an equally patched phpunit.xml)
Actual result BEFORE applying this Pull Request
no ldap tests (Tests: 784, Assertions: 1264, Skipped: 4.)
Expected result AFTER applying this Pull Request
5 more tests, 3 more assertions, 2 more skipped test (waiting for PRs #37962 and #37959)
Documentation Changes Required
Maybe: need to run the ldap docker image to run tests
tests/Unit/README.md should be updated on how to run the unit tests locally. I can add this once the general idea of this PR is approved.