[4.0] Implement char counter for input field, too #35678

bembelimen · 2021-09-27T04:28:45Z

Summary of Changes

Enabled character counter for text fields

Testing Instructions

Apply patch
NPM i
Open components/com_users/forms/registration.xml
Add the following attributes to the "name" field:
maxlength="30" charcounter="true"
Go to the frontend registration and check the name field

Actual result BEFORE applying this Pull Request

Nothing different

Expected result AFTER applying this Pull Request

brianteeman · 2021-09-27T07:11:02Z

Could this option be added to the custom fields as well?

libraries/src/Form/Field/TextField.php

Co-authored-by: Richard Fath <[email protected]>

bembelimen · 2021-09-27T08:01:23Z

Could this option be added to the custom fields as well?

In theory, it could be added to any (input/textarea) field. Currently I activate it manually in my override via:
$form->setFieldAttribute('fieldname', 'charcounter', 'true', 'com_fields'); and it works "out-of-the-box".

But that's currently a "bigger" problem in Joomla! (in my opinion): we use for every field an unique layout (which is good on one side) but therefore are very inconsistent over all (like the suffix/prefix info are only available for normal text fields and not for e.g. number fields etc.).
Probably worth to have there a nicer solution.

brianteeman · 2021-09-27T08:08:58Z

like the suffix/prefix info are only available for normal text fields and not for e.g. number fields etc.

That is a bug that should be fixed ;)

bembelimen · 2021-09-27T08:13:42Z

like the suffix/prefix info are only available for normal text fields and not for e.g. number fields etc.

That is a bug that should be fixed ;)

Yes and no, it's failure by design :) the number field does not extend the text field and the layouts could be one base layout with just different attributes....But I guess this counts for many fields (like all dropdowns etc.)

brianteeman · 2021-09-27T08:16:00Z

it's failure by design :)

or by omission

brianteeman · 2021-09-27T08:16:30Z

I have tested this item ✅ successfully on 97294eb

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35678.}

dgrammatiko · 2021-09-27T11:29:45Z

@bembelimen I wouldn't enable that before fixing the counter to work nicely for repeatable fields. BTW the project should review the fields compatibility with repeatable fields and patch what's broken (ie a field with a counter in a repeatable will work only for the first instance, all others will miss the counter because there's no event to trigger the initialization...)

bembelimen · 2021-09-27T11:32:55Z

Hi @dgrammatiko do you mean this PR (as the problem is the same with textareas then) or the spreading over all fields?

dgrammatiko · 2021-09-27T11:36:04Z

as the problem is the same with textareas

Yes, the initialization of that script is missing the listener for subform add/removal part

the spreading over all fields?

There are many core fields that have issues or not working at all in subforms. Some are easy to patch (ie this one) others need some more changes

brianteeman · 2021-09-27T11:37:47Z

it will be more of an issue with this field - and I see an issue whereby the capabilities of a custom field are not in sync with an xml field.

I agree that all fields need to be reviewed with subforms - there are already a few open issues but thats beyond the scope here (I think)

build/build-modules-js/init/patches.es6.js

dgrammatiko · 2021-09-27T11:58:54Z

it will be more of an issue with this field - and I see an issue whereby the capabilities of a custom field are not in sync with an xml field.

Probably the repeatable versions of input and textarea need also an update to expose this feature (if it's not already exposed, I haven't checked the code, I was commenting on the base that the core fields should play nicely with repeatables).
Anyways I provided the code needed

brianteeman · 2021-09-29T19:35:11Z

But that's currently a "bigger" problem in Joomla! (in my opinion): we use for every field an unique layout (which is good on one side) but therefore are very inconsistent over all (like the suffix/prefix info are only available for normal text fields and not for e.g. number fields etc.).

I just checked. Suffix and Prefix are available for every field - it is in the render options

RickR2H · 2021-09-30T14:12:46Z

I have tested this item ✅ successfully on 97294eb

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35678.}

richard67 · 2021-10-03T18:53:01Z

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35678.}

dgrammatiko · 2021-10-03T19:23:28Z

@richard67 my comment is still valid, introducing this without support for repeatable fields is plain wrong 😑

richard67 · 2021-10-03T19:28:26Z

@richard67 my comment is still valid, introducing this without support for repeatable fields is plain wrong 😑

@dgrammatiko Sorry, was not clear to me that there is something remaining to be done since the PR has got 2 test.

@bembelimen What's the status of this PR? You want to leave it as it is, or do you want to adapt it to support repeatable fields?

richard67 · 2021-10-03T19:29:04Z

Back to pending due to ongoing clarifications.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35678.}

richard67 · 2021-11-13T13:48:20Z

Needs review.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35678.}

mgscreativa · 2022-07-20T13:01:48Z

Hi! just using the brand new charcounter param in my edit message form like this

	<field
		name="title"
		type="text"
		label="COM_JAPPPUSH_FIELD_MESSAGE_TITLE_LABEL"
		maxlength="35"
		charcounter="true"
		required="true"
	/>

	<field
		name="body"
		type="textarea"
		label="COM_JAPPPUSH_FIELD_MESSAGE_BODY_LABEL"
		maxlength="160"
		charcounter="true"
	/>

Is it possible to apply this to the text input?

Thanks!

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35678.}

richard67 · 2022-07-20T13:08:14Z

Is it possible to apply this to the text input?

@mgscreativa Isn't that exactly what this pull request (PR) here here is doing?

If so, please test this PR and then mark your test result by going to the issue tracker here https://issues.joomla.org/tracker/joomla-cms/35678 and then using the blue "Test this" button at the top left corner, selecting the appropriate test result and submitting.

Every PR needs 2 successful tests by a human to get accepted, so if this PR solves your problem then please test it as described to bring it forward. Thanks in advance.

mgscreativa · 2022-07-21T18:33:24Z

I have tested this item ✅ successfully on ae922dc

Tested ok, no issues!

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35678.}

mgscreativa · 2022-07-21T18:34:22Z

Hi @richard67 done testing, works ok! Hope it gets in J 4.1

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35678.}

mgscreativa

Tested and it works just fine!

build/build-modules-js/init/patches.es6.js

RickR2H · 2022-07-29T15:53:57Z

@bembelimen After building I get the error: Uncaught SyntaxError: missing ) after argument list (at short-and-sweet.min.js?1.0.4:10:104)
Don't know if it is related, but the counter does not show up. Could you take a look?

richard67 · 2022-07-29T16:23:20Z

@bembelimen After building I get the error: Uncaught SyntaxError: missing ) after argument list (at short-and-sweet.min.js?1.0.4:10:104)
Don't know if it is related, but the counter does not show up. Could you take a look?

Previous review comment already mentioned that. There is indeed a syntax error in the js. The closing single quote of a query selector string is missing.

mgscreativa · 2022-08-15T19:09:57Z

Hi! is there anything else I can do to helpo this PR to pass? I'm using it in my site and it works just fine.

Thanks!

richard67 · 2022-08-15T19:12:45Z

As long as @bembelimen does not fix the syntax error in the JS mentioned above, it can not be accepted.

mgscreativa · 2022-08-17T12:16:23Z

Hi @richard67 can I send another PR with the same changes to try to pass it through?

mgscreativa · 2022-08-17T12:26:30Z

Hi! @bembelimen would yo be so kind to review this typo here to be able to pass this PR? https://github.com/joomla/joomla-cms/pull/35678/files#r926994733

Thanks!

mgscreativa · 2022-08-26T14:14:11Z

Hi @richard67 Can I send a fresh new PR to pass this new feature? Because the original PR author doesn't respond at all...

richard67 · 2022-08-26T14:16:57Z

Hi @richard67 Can I send a fresh new PR to pass this new feature? Because the original PR author doesn't responds at all...

@mgscreativa Let's wait a bit more. I've just notified him again.

obuisard · 2022-09-23T21:55:20Z

I have tested this item ✅ successfully on e13df24

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35678.}

sdwjoomla · 2022-09-23T21:56:54Z

I have tested this item ✅ successfully on e13df24

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35678.}

obuisard · 2022-09-24T01:14:51Z

Thank you Benjamin @bembelimen!

obuisard · 2022-09-24T16:24:36Z

Documentation found under https://docs.joomla.org/Text_form_field_type

Implement char counter for input field, too

b57b3b2

joomla-cms-bot added the PR-4.0-dev label Sep 27, 2021

richard67 reviewed Sep 27, 2021

View reviewed changes

libraries/src/Form/Field/TextField.php Outdated Show resolved Hide resolved

Update libraries/src/Form/Field/TextField.php

97294eb

Co-authored-by: Richard Fath <[email protected]>

dgrammatiko reviewed Sep 27, 2021

View reviewed changes

build/build-modules-js/init/patches.es6.js Outdated Show resolved Hide resolved

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 3, 2021

richard67 removed the RTC This Pull Request is Ready To Commit label Oct 3, 2021

Take subforms in account, too

af235c3

chmst changed the base branch from 4.0-dev to 4.1-dev January 31, 2022 16:37

Merge branch '4.1-dev' into 4.0/charcounter-textfield

5752c5c

chmst added PR-4.1-dev and removed PR-4.0-dev labels Jan 31, 2022

richard67 removed the PR-4.1-dev label Jul 20, 2022

mgscreativa approved these changes Jul 21, 2022

View reviewed changes

build/build-modules-js/init/patches.es6.js Outdated Show resolved Hide resolved

bembelimen changed the base branch from 4.2-dev to 4.3-dev August 17, 2022 23:12

Merge branch '4.3-dev' into 4.0/charcounter-textfield

50167a6

joomla-cms-bot added the PR-4.3-dev label Aug 17, 2022

Quy removed the PR-4.2-dev label Aug 18, 2022

bembelimen and others added 4 commits September 10, 2022 01:07

Merge branch '4.3-dev' into 4.0/charcounter-textfield

1722423

Fix JS error

99b7c66

Merge branch '4.3-dev' into 4.0/charcounter-textfield

2ecaec7

Merge branch '4.3-dev' into 4.0/charcounter-textfield

e13df24

Merge branch '4.3-dev' into 4.0/charcounter-textfield

3f5ab66

obuisard added this to the Joomla! 4.3.0 milestone Sep 24, 2022

obuisard merged commit f19fa75 into joomla:4.3-dev Sep 24, 2022

dgrammatiko mentioned this pull request Feb 28, 2023

Subform-repeatable javascript #39964

Closed

Uh oh!

[4.0] Implement char counter for input field, too #35678

[4.0] Implement char counter for input field, too #35678

Uh oh!

Conversation

bembelimen commented Sep 27, 2021

Summary of Changes

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Uh oh!

brianteeman commented Sep 27, 2021

Uh oh!

Uh oh!

bembelimen commented Sep 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brianteeman commented Sep 27, 2021

Uh oh!

bembelimen commented Sep 27, 2021

Uh oh!

brianteeman commented Sep 27, 2021

Uh oh!

brianteeman commented Sep 27, 2021

Uh oh!

dgrammatiko commented Sep 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bembelimen commented Sep 27, 2021

Uh oh!

dgrammatiko commented Sep 27, 2021

Uh oh!

brianteeman commented Sep 27, 2021

Uh oh!

Uh oh!

dgrammatiko commented Sep 27, 2021

Uh oh!

brianteeman commented Sep 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RickR2H commented Sep 30, 2021

Uh oh!

richard67 commented Oct 3, 2021

Uh oh!

dgrammatiko commented Oct 3, 2021

Uh oh!

richard67 commented Oct 3, 2021

Uh oh!

richard67 commented Oct 3, 2021

Uh oh!

richard67 commented Nov 13, 2021

Uh oh!

mgscreativa commented Jul 20, 2022

Uh oh!

richard67 commented Jul 20, 2022

Uh oh!

mgscreativa commented Jul 21, 2022

Uh oh!

mgscreativa commented Jul 21, 2022

Uh oh!

mgscreativa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

RickR2H commented Jul 29, 2022

Uh oh!

richard67 commented Jul 29, 2022

Uh oh!

mgscreativa commented Aug 15, 2022

Uh oh!

richard67 commented Aug 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mgscreativa commented Aug 17, 2022

Uh oh!

mgscreativa commented Aug 17, 2022

Uh oh!

mgscreativa commented Aug 26, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bembelimen commented Sep 27, 2021 •

edited

Loading

dgrammatiko commented Sep 27, 2021 •

edited

Loading

brianteeman commented Sep 29, 2021 •

edited

Loading

richard67 commented Aug 15, 2022 •

edited

Loading

mgscreativa commented Aug 26, 2022 •

edited

Loading