Skip to content

Conversation

@laoneo
Copy link
Member

@laoneo laoneo commented Aug 8, 2022

Activates the extension unit tests as default and does remove some deprecated messages in the tests.

Before the pr

image

After the pr

image

@joomla-cms-bot
Copy link

Please add more information to your issue. Without test instructions and/or any description we will close this issue within 4 weeks. Thanks.
This is an automated message from the J!Tracker Application.

@Hackwar
Copy link
Member

Hackwar commented Aug 8, 2022

Thanks for checking this. I doubt that we can merge this without fixing the tests first.

@heelc29
Copy link
Contributor

heelc29 commented Aug 8, 2022

@laoneo see Digital-Peak#27 for missing namespaces

* fix namespacemap

* fix JPath constants for win
@laoneo
Copy link
Member Author

laoneo commented Aug 9, 2022

@Hackwar can you have a look on this pr, as it is ready now?

@laoneo laoneo changed the base branch from 4.2-dev to 4.3-dev August 15, 2022 05:25
@laoneo laoneo requested a review from wilsonge as a code owner August 15, 2022 05:25
@laoneo laoneo removed the PR-4.2-dev label Aug 15, 2022
@laoneo laoneo changed the title Activate all unit tests as default [4.3] Activate all unit tests as default Aug 15, 2022
@wilsonge
Copy link
Contributor

Think the merge through has gone wrong. You've lost an entire plugin here :)

@laoneo
Copy link
Member Author

laoneo commented Aug 15, 2022

When 4.3 is up to date, then the pr should be fine again. Do you mean this plugin 31a2677?

@obuisard
Copy link
Contributor

Thank you @laoneo for the PR

@obuisard obuisard merged commit 0805889 into joomla:4.3-dev Aug 25, 2022
@obuisard obuisard added this to the Joomla! 4.3.0 milestone Aug 25, 2022
@laoneo laoneo deleted the j4/tests/plugins branch August 25, 2022 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants