-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[4.0] Revert #33839 - accessibility break [a11y] #33865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It is absolutely not necessary to change titles to tooltips. It is a pointless exercise with zero benefits that would need to be done in a gazillion places. The only time we should be using the black tooltips is as a replacement for the bootstrap tooltips. They are NOT a replacement for titles.
|
@brianteeman Should #33748 and #33776 be reverted, too? |
|
To me it seems so because there were titles before. |
|
Please look at the code, I don't know, whether this should be there or not |
|
This is clearly a tooltip as its an extended description As is this Titles are generally pretty useless https://silktide.com/blog/i-thought-title-text-improved-accessibility-i-was-wrong/ and I personally try to avoid them but there is nothing wrong with having it for something simple and people are used to them. Replacing all titles with these tooltips "just because" is a pointless exercise - its also a disruption to the content. Titles only appear after a delay. These tooltips appear immediately so you really dont want to have them everywhere. |
|
@rjharishabh no idea what you are talking about |
Got it |
Line 285 and 289 |
|
read the code again |
|
I really have no idea what you are talking about. |
|
see #33839 (comment) the issue is not accessibility but getting a readable tip. I am not in favor of reverting. On the contrary. |
|
So why have you not insisted that these were tooltips for the last 8 years with Joomla 3? Makes no sense to me other than being contrary |
|
This issue is also about accessibility. It actually breaks accessibility!! With this PR every links to a category is identified by assistive technology as "Edit Category" |
|
@brianteeman It's still not clear to me if #33748 and #33776 should be reverted, too. |
|
They serve a purpose as its giving an instruction and otherwise we only have an icon |
I did not propose that one, but only the Edit articles @rjharishabh |
|
@infograf768 No problem |
|
I have tested this item ✅ successfully on b10e158 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33865. |
|
Thanks for writing the document. The examples about what the screen reader will announce is not quite correct as it will depend on several factors such as the screen reader mode, level of verbosity etc. As sighted people its very hard to test for screen readers as there are different levels of expectation about what will be announced AND there is no need to add words such as link or image as they are provided by the screen reader. I would prefer it if the recommendation was to use the tooltip when there is additional information provided only. |
|
I have tested this item ✅ successfully on b10e158 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33865. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33865. |
|
Thank you! |
|
Thanks |


It is absolutely not necessary to change titles to tooltips. It is a pointless exercise with zero benefits that would need to be done in a gazillion places.
The only time we should be using the black tooltips is as a replacement for the bootstrap tooltips. They are NOT a replacement for titles.
In this specific case the category links now all have the exact same name "edit category" which is obviously an accessibility fail