Skip to content

Conversation

@brianteeman
Copy link
Contributor

@brianteeman brianteeman commented May 14, 2021

It is absolutely not necessary to change titles to tooltips. It is a pointless exercise with zero benefits that would need to be done in a gazillion places.

The only time we should be using the black tooltips is as a replacement for the bootstrap tooltips. They are NOT a replacement for titles.

In this specific case the category links now all have the exact same name "edit category" which is obviously an accessibility fail

It is absolutely not necessary to change titles to tooltips. It is a pointless exercise with zero benefits that would need to be done in a gazillion places.

The only time we should be using the black tooltips is as a replacement for the bootstrap tooltips. They are NOT a replacement for titles.
@richard67
Copy link
Member

@brianteeman Should #33748 and #33776 be reverted, too?

@richard67
Copy link
Member

To me it seems so because there were titles before.

@rjharishabh
Copy link
Contributor

Please look at the code, starting tag in one if and closing tag in another if with the same condition

I don't know, whether this should be there or not

@brianteeman
Copy link
Contributor Author

This is clearly a tooltip as its an extended description

image

As is this

image

Titles are generally pretty useless https://silktide.com/blog/i-thought-title-text-improved-accessibility-i-was-wrong/ and I personally try to avoid them but there is nothing wrong with having it for something simple and people are used to them.

Replacing all titles with these tooltips "just because" is a pointless exercise - its also a disruption to the content. Titles only appear after a delay. These tooltips appear immediately so you really dont want to have them everywhere.

@brianteeman
Copy link
Contributor Author

@rjharishabh no idea what you are talking about

@rjharishabh
Copy link
Contributor

Titles are generally pretty useless https://silktide.com/blog/i-thought-title-text-improved-accessibility-i-was-wrong/ and I personally try to avoid them but there is nothing wrong with having it for something simple and people are used to them.

Replacing all titles with these tooltips "just because" is a pointless exercise - its also a disruption to the content. Titles only appear after a delay. These tooltips appear immediately so you really dont want to have them everywhere.

Got it

@rjharishabh
Copy link
Contributor

@rjharishabh no idea what you are talking about

Line 285 and 289

@brianteeman
Copy link
Contributor Author

read the code again

@brianteeman
Copy link
Contributor Author

I really have no idea what you are talking about.

@infograf768
Copy link
Member

see #33839 (comment)

the issue is not accessibility but getting a readable tip. I am not in favor of reverting. On the contrary.

@brianteeman
Copy link
Contributor Author

So why have you not insisted that these were tooltips for the last 8 years with Joomla 3? Makes no sense to me other than being contrary

@brianteeman
Copy link
Contributor Author

This issue is also about accessibility. It actually breaks accessibility!!

With this PR every links to a category is identified by assistive technology as "Edit Category"

@brianteeman brianteeman changed the title [4.0] Revert #33839 [4.0] Revert #33839 - accessibility break [a11y] May 14, 2021
@richard67
Copy link
Member

@brianteeman It's still not clear to me if #33748 and #33776 should be reverted, too.

@brianteeman
Copy link
Contributor Author

They serve a purpose as its giving an instruction and otherwise we only have an icon

@infograf768
Copy link
Member

With this PR every links to a category is identified by assistive technology as "Edit Category"

I did not propose that one, but only the Edit articles
#33776 (comment)

@rjharishabh
Sorry if this is totally reverted as I was the one who proposed the tip change.

@rjharishabh
Copy link
Contributor

@infograf768 No problem

@ceford
Copy link
Contributor

ceford commented May 15, 2021

I have tested this item ✅ successfully on b10e158

I was amongst those who passed the pr that created this problem. That was on the grounds that having different tip types on adjacent items just looks wrong. I have written something about this to point to when someone comes along next week or next month to do the previous pr again: https://docs.joomla.org/Joomla_4_Tips_and_Tricks:_Titles_and_Tooltips - we can't always rely on @brianteeman's vigilance.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33865.

@brianteeman
Copy link
Contributor Author

brianteeman commented May 15, 2021

Thanks for writing the document. The examples about what the screen reader will announce is not quite correct as it will depend on several factors such as the screen reader mode, level of verbosity etc. As sighted people its very hard to test for screen readers as there are different levels of expectation about what will be announced AND there is no need to add words such as link or image as they are provided by the screen reader. I would prefer it if the recommendation was to use the tooltip when there is additional information provided only.

@saumyasarkar11
Copy link
Contributor

I have tested this item ✅ successfully on b10e158


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33865.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33865.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 15, 2021
@richard67 richard67 added this to the Joomla 4.0 milestone May 15, 2021
@Quy Quy merged commit ff9d2aa into joomla:4.0-dev May 15, 2021
@Quy
Copy link
Contributor

Quy commented May 15, 2021

Thank you!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 15, 2021
@brianteeman
Copy link
Contributor Author

Thanks

@brianteeman brianteeman deleted the revert branch May 15, 2021 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants