Skip to content

Commit b10e158

Browse files
committed
[4.0] Revert #33839
It is absolutely not necessary to change titles to tooltips. It is a pointless exercise with zero benefits that would need to be done in a gazillion places. The only time we should be using the black tooltips is as a replacement for the bootstrap tooltips. They are NOT a replacement for titles.
1 parent e770fe3 commit b10e158

File tree

1 file changed

+21
-14
lines changed
  • administrator/components/com_content/tmpl/articles

1 file changed

+21
-14
lines changed

administrator/components/com_content/tmpl/articles/default.php

Lines changed: 21 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -257,9 +257,8 @@
257257
<?php echo HTMLHelper::_('jgrid.checkedout', $i, $item->editor, $item->checked_out_time, 'articles.', $canCheckin); ?>
258258
<?php endif; ?>
259259
<?php if ($canEdit || $canEditOwn) : ?>
260-
<a href="<?php echo Route::_('index.php?option=com_content&task=article.edit&id=' . $item->id); ?>" aria-labelledby="edit-<?php echo (int) $item->id; ?>">
260+
<a href="<?php echo Route::_('index.php?option=com_content&task=article.edit&id=' . $item->id); ?>" title="<?php echo Text::_('JACTION_EDIT'); ?> <?php echo $this->escape($item->title); ?>">
261261
<?php echo $this->escape($item->title); ?></a>
262-
<div role="tooltip" id="edit-<?php echo (int) $item->id; ?>"><?php echo Text::_('JACTION_EDIT') . ' ' . $this->escape($item->title); ?></div>
263262
<?php else : ?>
264263
<span title="<?php echo Text::sprintf('JFIELD_ALIAS_LABEL', $this->escape($item->alias)); ?>"><?php echo $this->escape($item->title); ?></span>
265264
<?php endif; ?>
@@ -284,33 +283,41 @@
284283
if (Factory::getLanguage()->isRtl())
285284
{
286285
if ($canEditCat || $canEditOwnCat) :
287-
echo '<a href="' . $CurrentCatUrl . '" aria-labelledby="edit-cat-' . (int) $item->id . '">';
288-
echo $this->escape($item->category_title). '</a>';
289-
echo '<div role="tooltip" id="edit-cat-' . (int) $item->id.'">' . $EditCatTxt . '</div>';
286+
echo '<a href="' . $CurrentCatUrl . '" title="' . $EditCatTxt . '">';
287+
endif;
288+
echo $this->escape($item->category_title);
289+
if ($canEditCat || $canEditOwnCat) :
290+
echo '</a>';
290291
endif;
291292
if ($item->category_level != '1') :
292293
echo ' &#171; ';
293294
if ($canEditParCat || $canEditOwnParCat) :
294-
echo '<a href="' . $ParentCatUrl . '" aria-labelledby="edit-cat-' . (int) $item->id . '">';
295-
echo $this->escape($item->parent_category_title) . '</a>';
296-
echo '<div role="tooltip" id="edit-cat-' . (int) $item->id.'">' . $EditCatTxt . '</div>';
295+
echo '<a href="' . $ParentCatUrl . '" title="' . $EditCatTxt . '">';
296+
endif;
297+
echo $this->escape($item->parent_category_title);
298+
if ($canEditParCat || $canEditOwnParCat) :
299+
echo '</a>';
297300
endif;
298301
endif;
299302
}
300303
else
301304
{
302305
if ($item->category_level != '1') :
303306
if ($canEditParCat || $canEditOwnParCat) :
304-
echo '<a href="' . $ParentCatUrl . '" aria-labelledby="edit-cat-' . (int) $item->id . '">';
305-
echo $this->escape($item->parent_category_title) . '</a>';
306-
echo '<div role="tooltip" id="edit-cat-' . (int) $item->id.'">' . $EditCatTxt . '</div>';
307+
echo '<a href="' . $ParentCatUrl . '" title="' . $EditCatTxt . '">';
308+
endif;
309+
echo $this->escape($item->parent_category_title);
310+
if ($canEditParCat || $canEditOwnParCat) :
311+
echo '</a>';
307312
endif;
308313
echo ' &#187; ';
309314
endif;
310315
if ($canEditCat || $canEditOwnCat) :
311-
echo '<a href="' . $CurrentCatUrl . '" aria-labelledby="edit-cat-' . (int) $item->id . '">';
312-
echo $this->escape($item->category_title) . '</a>';
313-
echo '<div role="tooltip" id="edit-cat-' . (int) $item->id . '">' . $EditCatTxt . '</div>';
316+
echo '<a href="' . $CurrentCatUrl . '" title="' . $EditCatTxt . '">';
317+
endif;
318+
echo $this->escape($item->category_title);
319+
if ($canEditCat || $canEditOwnCat) :
320+
echo '</a>';
314321
endif;
315322
}
316323
?>

0 commit comments

Comments
 (0)