Skip to content

Conversation

@rjharishabh
Copy link
Contributor

Pull Request for Issue # .

Summary of Changes

Add div role="tooltip"

Testing Instructions

Dashboard > Users > Messaging > Private Messages
If your site doesn't have any redirects, please create some redirects using New
tooltip com message
Hover on icons present in Read column
Apply PR
Again hover and see the difference

Actual result BEFORE applying this Pull Request

Non-Joomla style tooltip

Expected result AFTER applying this Pull Request

Joomla style tooltip

Documentation Changes Required

No

@rjharishabh rjharishabh changed the title [4.0] Add Joomla style tooltip in com-messages [4.0] Add Joomla style tooltip in com_messages May 11, 2021
@Quy
Copy link
Contributor

Quy commented May 11, 2021

I have tested this item ✅ successfully on 7018148


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33776.

1 similar comment
@ghost
Copy link

ghost commented May 12, 2021

I have tested this item ✅ successfully on 7018148


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33776.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33776.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 12, 2021
@richard67 richard67 added this to the Joomla 4.0 milestone May 12, 2021
@infograf768 infograf768 merged commit 85d42d2 into joomla:4.0-dev May 13, 2021
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 13, 2021
@infograf768
Copy link
Member

tks

@rjharishabh rjharishabh deleted the tooltip-com-messages branch May 13, 2021 06:46
@rjharishabh
Copy link
Contributor Author

Thanks for merging

@infograf768
Copy link
Member

@rjharishabh

If you have time, you maybe could also change title to tooltip for the Managers where we have

Screen Shot 2021-05-13 at 08 47 21

Using (here for articles) something like

										<?php endif; ?>
										<?php if ($canEdit || $canEditOwn) : ?>
											<a href="<?php echo Route::_('index.php?option=com_content&task=article.edit&id=' . $item->id); ?>" aria-labelledby="edit-<?php echo (int) $item->id; ?>">
												<?php echo $this->escape($item->title); ?></a>
											<div role="tooltip" id="edit-<?php echo (int) $item->id; ?>"><?php echo Text::_('JACTION_EDIT'); ?> <?php echo $this->escape($item->title); ?></div>
										<?php else : ?>

 to get
 
Screen Shot 2021-05-13 at 08 56 51

@rjharishabh
Copy link
Contributor Author

@infograf768 I will look into it soon

@rjharishabh
Copy link
Contributor Author

@infograf768 PR #33839

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants